Remove SpdyFramerVisitorInterface::OnControlFrameHeaderData().

net/spdy/spdy_deframer_visitor.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_deframer_visitor.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include <algorithm>
@@ skipping 127 matching lines @@
   // as in SpdyFramerVisitorInterface.
   void OnAltSvc(SpdyStreamId stream_id,
                 StringPiece origin,
                 const SpdyAltSvcWireFormat::AlternativeServiceVector&
                     altsvc_vector) override;
   void OnBlocked(SpdyStreamId stream_id) override;
   void OnContinuation(SpdyStreamId stream_id, bool end) override;
   SpdyHeadersHandlerInterface* OnHeaderFrameStart(
       SpdyStreamId stream_id) override;
   void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override;
-  bool OnControlFrameHeaderData(SpdyStreamId stream_id,
-                                const char* header_data,
-                                size_t header_data_len) override;
   void OnDataFrameHeader(SpdyStreamId stream_id,
                          size_t length,
                          bool fin) override;
   void OnError(SpdyFramer* framer) override;
   void OnGoAway(SpdyStreamId last_accepted_stream_id,
                 SpdyGoAwayStatus status) override;
   bool OnGoAwayFrameData(const char* goaway_data, size_t len) override;
   void OnHeaders(SpdyStreamId stream_id,
                  bool has_priority,
                  int weight,
@@ skipping 300 matching lines @@
   CHECK_EQ(frame_type_, UNSET) << "   frame_type_="
                                << Http2FrameTypeToString(frame_type_);
   CHECK_GT(stream_id, 0u);
   CHECK_NE(nullptr, headers_.get());
   frame_type_ = CONTINUATION;
 
   stream_id_ = stream_id;
   end_ = end;
 }
 
-// Called with the decompressed contents of headers, in zero or more pieces
-// (i.e. an empty headers frame doesn't have any non-zero length data).
-// Note that the end of the headers is indicated by header_data==nullptr
-// AND header_data_len==0, even if there were no non-zero pieces.
-// SpdyHeadersBlockParser decodes these.
-// Returning false kills the connection (SpdyFramer enters state SPDY_ERROR).
-bool SpdyTestDeframerImpl::OnControlFrameHeaderData(SpdyStreamId stream_id,
-                                                    const char* header_data,
-                                                    size_t header_data_len) {
-  DVLOG(1) << "OnControlFrameHeaderData stream_id: " << stream_id
-           << "      len: " << header_data_len;
-  CHECK(frame_type_ == HEADERS || frame_type_ == CONTINUATION ||
-        frame_type_ == PUSH_PROMISE)
-      << "   frame_type_=" << Http2FrameTypeToString(frame_type_);
-  CHECK_EQ(stream_id_, stream_id);
-  LOG(FATAL) << "Must call SpdyFramer::set_use_new_methods_for_test(true)";
-  return true;
-}
-
 // Note that length includes the padding length (0 to 256, when the optional
 // padding length field is counted). Padding comes after the payload, both
 // for DATA frames and for control frames.
 void SpdyTestDeframerImpl::OnDataFrameHeader(SpdyStreamId stream_id,
                                              size_t length,
                                              bool fin) {
   DVLOG(1) << "OnDataFrameHeader stream_id: " << stream_id;
   CHECK_EQ(frame_type_, UNSET) << "   frame_type_="
                                << Http2FrameTypeToString(frame_type_);
   CHECK_GT(stream_id, 0u);
@@ skipping 603 matching lines @@
 // The SpdyFramer will not process any more data at this point.
 void DeframerCallbackCollector::OnError(SpdyFramer* framer,
                                         SpdyTestDeframer* deframer) {
   CollectedFrame cf;
   cf.error_reported = true;
   collected_frames_->push_back(std::move(cf));
 }
 
 }  // namespace test
 }  // namespace net