Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2436793002: Simplify SVGAnimated* initialization (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SVGAnimated* initialization In several cases, all initial values are the same, so callers of SVGAnimated<TYPE>::create can be relieved of the duty of calling SVG<TYPE>::create() explicitly. This affects: SVGAnimatedBoolean, SVGAnimatedNumberList, SVGAnimatedPreserveAspectRatio, SVGAnimatedString and SVGAnimatedTransformList These should hopefully also all reset to the correct value when encountering an invalid (string) value. BUG=225807 Committed: https://crrev.com/5b547dba8bd00bfe5882e1c8ee15dc49995e7531 Cr-Commit-Position: refs/heads/master@{#426429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -133 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedBoolean.h View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedHref.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedNumberList.h View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedPreserveAspectRatio.h View 2 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedString.h View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTransformList.h View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGComponentTransferFunctionElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeNodeElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
fs
4 years, 2 months ago (2016-10-19 19:04:10 UTC) #7
kouhei (in TOK)
lgtm
4 years, 2 months ago (2016-10-19 23:07:54 UTC) #9
pdr.
smaller code++ err, -- LGTM
4 years, 2 months ago (2016-10-20 03:17:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436793002/1
4 years, 2 months ago (2016-10-20 07:49:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 08:02:40 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b547dba8bd00bfe5882e1c8ee15dc49995e7531
Cr-Commit-Position: refs/heads/master@{#426429}

Powered by Google App Engine
This is Rietveld 408576698