third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp - Issue 2436793002: Simplify SVGAnimated* initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

Issue 2436793002: Simplify SVGAnimated* initialization (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

index 5806985fabd4621868d657b6f6807f488c78a61e..0f2018f44a9221f38de7fdf9a20ddb542c244643 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

@@ -40,9 +40,7 @@ inline SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement(

m_kernelUnitLength(SVGAnimatedNumberOptionalNumber::create(

this,

SVGNames::kernelUnitLengthAttr)),

- m_in1(SVGAnimatedString::create(this,

- SVGNames::inAttr,

- SVGString::create())) {

+ m_in1(SVGAnimatedString::create(this, SVGNames::inAttr)) {

addToPropertyMap(m_diffuseConstant);

addToPropertyMap(m_surfaceScale);

addToPropertyMap(m_kernelUnitLength);