Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGViewSpec.cpp

Issue 2436793002: Simplify SVGAnimated* initialization (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTextPositioningElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2010 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2010 Rob Buis <buis@kde.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 21 matching lines...) Expand all
32 SVGViewSpec::SVGViewSpec(SVGSVGElement* contextElement) 32 SVGViewSpec::SVGViewSpec(SVGSVGElement* contextElement)
33 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to 33 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to
34 // an element. We make tear-offs' contextElement the target element of 34 // an element. We make tear-offs' contextElement the target element of
35 // SVGViewSpec. This contextElement will be only used for keeping this 35 // SVGViewSpec. This contextElement will be only used for keeping this
36 // alive from the tearoff. SVGSVGElement holds a strong-ref to this 36 // alive from the tearoff. SVGSVGElement holds a strong-ref to this
37 // SVGViewSpec, so this is kept alive as: 37 // SVGViewSpec, so this is kept alive as:
38 // AnimatedProperty tearoff -(contextElement)-> SVGSVGElement -(RefPtr)-> 38 // AnimatedProperty tearoff -(contextElement)-> SVGSVGElement -(RefPtr)->
39 // SVGViewSpec. 39 // SVGViewSpec.
40 : SVGFitToViewBox(contextElement, PropertyMapPolicySkip), 40 : SVGFitToViewBox(contextElement, PropertyMapPolicySkip),
41 m_contextElement(contextElement), 41 m_contextElement(contextElement),
42 m_transform( 42 m_transform(SVGAnimatedTransformList::create(contextElement,
43 SVGAnimatedTransformList::create(contextElement, 43 SVGNames::transformAttr)) {
44 SVGNames::transformAttr,
45 SVGTransformList::create())) {
46 ASSERT(m_contextElement); 44 ASSERT(m_contextElement);
47 45
48 viewBox()->setReadOnly(); 46 viewBox()->setReadOnly();
49 preserveAspectRatio()->setReadOnly(); 47 preserveAspectRatio()->setReadOnly();
50 m_transform->setReadOnly(); 48 m_transform->setReadOnly();
51 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to 49 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to
52 // an element. 50 // an element.
53 } 51 }
54 52
55 DEFINE_TRACE(SVGViewSpec) { 53 DEFINE_TRACE(SVGViewSpec) {
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 226
229 if (!skipExactly<CharType>(ptr, end, ')')) 227 if (!skipExactly<CharType>(ptr, end, ')'))
230 return false; 228 return false;
231 229
232 skipExactly<CharType>(ptr, end, ';'); 230 skipExactly<CharType>(ptr, end, ';');
233 } 231 }
234 return skipExactly<CharType>(ptr, end, ')'); 232 return skipExactly<CharType>(ptr, end, ')');
235 } 233 }
236 234
237 } // namespace blink 235 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTextPositioningElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698