Never use the hermetic xcode toolchain for iOS recipes.

Never use the hermetic xcode toolchain for iOS recipes.

Previously, I was using TARGET_PLATFORM == 'mac' to turn on the hermetic xcode
toolchain. Unfortunately, this conditional evalutes to true for iOS recipes as
well. Explicitly turn off the hermetic xcode toolchain in this recipe.

BUG=626093
Committed: https://chromium.googlesource.com/chromium/tools/build/+/eb46e3c1bfd1a8dcc9be13eb857e374aa9f5c66e

[erikchen, 2016-10-20 00:59:07]

erikchen@chromium.org changed reviewers:
+ smut@google.com

[erikchen, 2016-10-20 00:59:08]

smut: Please review.

[erikchen, 2016-10-20 01:01:03]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 01:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 01:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 01:01:06]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[erikchen, 2016-10-21 20:57:31]

On 2016/10/20 00:59:08, erikchen wrote:
> smut: Please review.

smut: Ping

[smut, 2016-10-21 21:14:18]

Not a huge fan of this. If you re-order the config applications then
FORCE_MAC_TOOLCHAIN will be 1.

Can you change the FORCE_MAC_TOOLCHAIN variable to just not be set for iOS in
the first place?

Lgtm if not.

[erikchen, 2016-10-21 21:38:50]

On 2016/10/21 21:14:18, smut wrote:
> Not a huge fan of this. If you re-order the config applications then
> FORCE_MAC_TOOLCHAIN will be 1.
> 
> Can you change the FORCE_MAC_TOOLCHAIN variable to just not be set for iOS in
> the first place?
> 
> Lgtm if not.

How do you suggest setting FORCE_MAC_TOOLCHAIN on every recipe except the ones
in ios? I was hoping to use TARGET_PLATFORM, but it appears that wraps in ios as
well.

[erikchen, 2016-10-21 22:04:37]

On 2016/10/21 21:38:50, erikchen wrote:
> On 2016/10/21 21:14:18, smut wrote:
> > Not a huge fan of this. If you re-order the config applications then
> > FORCE_MAC_TOOLCHAIN will be 1.
How so? The default value for FORCE_MAC_TOOLCHAIN gets set by BASE, so any time
this config is applied, it is guaranteed to override the default.

[smut, 2016-10-21 22:19:32]

On 2016/10/21 22:04:37, erikchen wrote:
> On 2016/10/21 21:38:50, erikchen wrote:
> > On 2016/10/21 21:14:18, smut wrote:
> > > Not a huge fan of this. If you re-order the config applications then
> > > FORCE_MAC_TOOLCHAIN will be 1.
> How so? The default value for FORCE_MAC_TOOLCHAIN gets set by BASE, so any
time
> this config is applied, it is guaranteed to override the default.

According to the docs, BASE has is_root set so every Chromium config application
applies BASE first. Doesn't that mean if you apply force_mac_toolchain_off then
apply a second config, that second config applies BASE which resets
FORCE_MAC_TOOLCHAIN to 1? Can you do a check in BASE and only set
FORCE_MAC_TOOLCHAIN=1 if not iOS?

[erikchen, 2016-10-21 22:50:00]

On 2016/10/21 22:19:32, smut wrote:
> On 2016/10/21 22:04:37, erikchen wrote:
> > On 2016/10/21 21:38:50, erikchen wrote:
> > > On 2016/10/21 21:14:18, smut wrote:
> > > > Not a huge fan of this. If you re-order the config applications then
> > > > FORCE_MAC_TOOLCHAIN will be 1.
> > How so? The default value for FORCE_MAC_TOOLCHAIN gets set by BASE, so any
> time
> > this config is applied, it is guaranteed to override the default.
> 
> According to the docs, BASE has is_root set so every Chromium config
application
> applies BASE first. Doesn't that mean if you apply force_mac_toolchain_off
then
> apply a second config, that second config applies BASE which resets
> FORCE_MAC_TOOLCHAIN to 1? Can you do a check in BASE and only set
> FORCE_MAC_TOOLCHAIN=1 if not iOS?

BASE does not get reapplied, so re-ordering isn't an issue. There is, to the
best of my knowledge, to better way of checking platform than TARGET_PLATFORM.

[erikchen, 2016-10-21 22:50:05]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 23:04:55]

Description was changed from

==========
Never use the hermetic xcode toolchain for iOS recipes.

Previously, I was using TARGET_PLATFORM == 'mac' to turn on the hermetic xcode
toolchain. Unfortunately, this conditional evalutes to true for iOS recipes as
well. Explicitly turn off the hermetic xcode toolchain in this recipe.

BUG=626093
==========

to

==========
Never use the hermetic xcode toolchain for iOS recipes.

Previously, I was using TARGET_PLATFORM == 'mac' to turn on the hermetic xcode
toolchain. Unfortunately, this conditional evalutes to true for iOS recipes as
well. Explicitly turn off the hermetic xcode toolchain in this recipe.

BUG=626093

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/eb46e3c1bfd1a8dcc9be...
==========

[commit-bot: I haz the power, 2016-10-21 23:04:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/eb46e3c1bfd1a8dcc9be...