scripts/slave/recipes/ios/try.expected/icu_patch.json - Issue 2436723003: Never use the hermetic xcode toolchain for iOS recipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/ios/try.expected/icu_patch.json

Issue 2436723003: Never use the hermetic xcode toolchain for iOS recipes. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/ios/try.expected/icu_patch.json

diff --git a/scripts/slave/recipes/ios/try.expected/icu_patch.json b/scripts/slave/recipes/ios/try.expected/icu_patch.json

index 7c7955129a0d8521f0caef70de1c461639048c54..c2bb77bc302d4296a3a326d6e0c5242289f16f5c 100644

--- a/scripts/slave/recipes/ios/try.expected/icu_patch.json

+++ b/scripts/slave/recipes/ios/try.expected/icu_patch.json

@@ -276,7 +276,7 @@

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "OS=ios component=static_library fake gyp define 1='fake value 1' fake gyp define 2='fake value 2'"

+ "GYP_DEFINES": "OS=ios component=static_library fake gyp define 1='fake value 1' fake gyp define 2='fake value 2' target_arch=x64"

"name": "analyze",

"~followup_annotations": [