scripts/slave/recipe_modules/ios/api.py - Issue 2436723003: Never use the hermetic xcode toolchain for iOS recipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/ios/api.py

Issue 2436723003: Never use the hermetic xcode toolchain for iOS recipes. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/ios/api.py

diff --git a/scripts/slave/recipe_modules/ios/api.py b/scripts/slave/recipe_modules/ios/api.py

index 5094c1f1967cc4b7fcc15bdf727888b15ded3d25..bad516a79f92afd2948788405187d7fdd018f11b 100644

--- a/scripts/slave/recipe_modules/ios/api.py

+++ b/scripts/slave/recipe_modules/ios/api.py

@@ -231,6 +231,7 @@ class iOSApi(recipe_api.RecipeApi):

cfg.gyp_env.GYP_DEFINES = dict(v.split('=') for

v in self.__config['GYP_DEFINES'])

self.m.chromium.c = cfg

+ self.m.chromium.apply_config('force_mac_toolchain_off')

use_goma = (cfg.gyp_env.GYP_DEFINES.get('use_goma') == '1' or

'use_goma=true' in self.__config['gn_args'])