Add EXTERNAL_POLICY to list of possible extension locations

Add EXTERNAL_POLICY to list of possible extension locations

This CL adds a new extension location, EXTERNAL_POLICY. This will be used
for CRX files that are force-installed through policy but instead of
being downloaded and installed directly, are cached on disk first.

BUG=287802
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225526

[bartfab (slow), 2013-09-23 18:25:03]

Hi Benjamin,

Could you review */extensions/*?

Hi Ilya,

Could you do an owner review for histograms.xml?

Hi Nikita,

Could you do an owner review for enterprise_extension_observer.cc?

Hi Finnur,

Could you do an owner review for extension_settings_handler.cc?

Hi Drew,

Could you do an owner review for background_contents_service.cc?

[not at google - send to devlin, 2013-09-23 21:17:31]

lgtm

https://codereview.chromium.org/24365004/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/management/management_api.cc (right):

https://codereview.chromium.org/24365004/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/management/management_api.cc:197: default:
could you remove the default case here? it stops the compiler from picking these
up.

https://codereview.chromium.org/24365004/diff/1/chrome/browser/ui/webui/exten...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

https://codereview.chromium.org/24365004/diff/1/chrome/browser/ui/webui/exten...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:196:
extension->location() == Manifest::EXTERNAL_POLICY_DOWNLOAD) {
there is a lot of this. perhaps add Manifest::IsPolicyLocation.

https://codereview.chromium.org/24365004/diff/1/extensions/common/manifest.h
File extensions/common/manifest.h (right):

https://codereview.chromium.org/24365004/diff/1/extensions/common/manifest.h#...
extensions/common/manifest.h:44: // policies).
this explanation is awfully similar to EXTERNAL_POLICY_DOWNLOAD. in fact I don't
really understand the difference. could you elaborate a bit?

https://codereview.chromium.org/24365004/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/24365004/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:21046: +  <int value="9"
label="EXTERNAL_POLICY"/>
could you add the COMMAND_LINE option here too?

[Ilya Sherman, 2013-09-23 21:32:31]

histograms.xml lgtm

[Finnur, 2013-09-24 09:38:37]

extension_settings_handler.cc LGTM

[Andrew T Wilson (Slow), 2013-09-24 11:22:37]

LGTM, but agreed that you should really add more documentation around why this
is needed (I'm assuming that the mechanism for getting the CRX file onto a CROS
device in this case is different somehow from the normal user-policy mechanism)?

[Nikita (slow), 2013-09-26 10:36:49]

lgtm

[bartfab (slow), 2013-09-26 14:29:52]

https://chromiumcodereview.appspot.com/24365004/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/management/management_api.cc (right):

https://chromiumcodereview.appspot.com/24365004/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/management/management_api.cc:197: default:
On 2013/09/23 21:17:32, kalman wrote:
> could you remove the default case here? it stops the compiler from picking
these
> up.

Done.

https://chromiumcodereview.appspot.com/24365004/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

https://chromiumcodereview.appspot.com/24365004/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:196:
extension->location() == Manifest::EXTERNAL_POLICY_DOWNLOAD) {
On 2013/09/23 21:17:32, kalman wrote:
> there is a lot of this. perhaps add Manifest::IsPolicyLocation.

Done.

https://chromiumcodereview.appspot.com/24365004/diff/1/extensions/common/mani...
File extensions/common/manifest.h (right):

https://chromiumcodereview.appspot.com/24365004/diff/1/extensions/common/mani...
extensions/common/manifest.h:44: // policies).
On 2013/09/23 21:17:32, kalman wrote:
> this explanation is awfully similar to EXTERNAL_POLICY_DOWNLOAD. in fact I
don't
> really understand the difference. could you elaborate a bit?

Done.

https://chromiumcodereview.appspot.com/24365004/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/24365004/diff/1/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:21046: +  <int value="9"
label="EXTERNAL_POLICY"/>
On 2013/09/23 21:17:32, kalman wrote:
> could you add the COMMAND_LINE option here too?

Done.

[commit-bot: I haz the power, 2013-09-26 14:30:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/24365004/12001

[commit-bot: I haz the power, 2013-09-26 18:50:16]

Change committed as 225526