Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/extensions/admin_policy.cc

Issue 24365004: Add EXTERNAL_POLICY to list of possible extension locations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/admin_policy.h" 5 #include "chrome/browser/extensions/admin_policy.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/common/extensions/extension.h" 8 #include "chrome/common/extensions/extension.h"
9 #include "extensions/common/manifest.h" 9 #include "extensions/common/manifest.h"
10 #include "grit/generated_resources.h" 10 #include "grit/generated_resources.h"
11 #include "ui/base/l10n/l10n_util.h" 11 #include "ui/base/l10n/l10n_util.h"
12 12
13 namespace { 13 namespace {
14 14
15 bool ManagementPolicyImpl(const extensions::Extension* extension, 15 bool ManagementPolicyImpl(const extensions::Extension* extension,
16 string16* error, 16 string16* error,
17 bool modifiable_value) { 17 bool modifiable_value) {
18 bool modifiable = 18 bool modifiable =
19 extension->location() != extensions::Manifest::COMPONENT && 19 extension->location() != extensions::Manifest::COMPONENT &&
20 extension->location() != extensions::Manifest::EXTERNAL_POLICY_DOWNLOAD; 20 !extensions::Manifest::IsPolicyLocation(extension->location());
21 // Some callers equate "no restriction" to true, others to false. 21 // Some callers equate "no restriction" to true, others to false.
22 if (modifiable) 22 if (modifiable)
23 return modifiable_value; 23 return modifiable_value;
24 24
25 if (error) { 25 if (error) {
26 *error = l10n_util::GetStringFUTF16( 26 *error = l10n_util::GetStringFUTF16(
27 IDS_EXTENSION_CANT_MODIFY_POLICY_REQUIRED, 27 IDS_EXTENSION_CANT_MODIFY_POLICY_REQUIRED,
28 UTF8ToUTF16(extension->name())); 28 UTF8ToUTF16(extension->name()));
29 } 29 }
30 return !modifiable_value; 30 return !modifiable_value;
(...skipping 23 matching lines...) Expand all
54 const base::ListValue* whitelist, 54 const base::ListValue* whitelist,
55 const base::DictionaryValue* forcelist, 55 const base::DictionaryValue* forcelist,
56 const base::ListValue* allowed_types, 56 const base::ListValue* allowed_types,
57 const Extension* extension, 57 const Extension* extension,
58 string16* error) { 58 string16* error) {
59 // Component extensions are always allowed. 59 // Component extensions are always allowed.
60 if (extension->location() == Manifest::COMPONENT) 60 if (extension->location() == Manifest::COMPONENT)
61 return true; 61 return true;
62 62
63 // Forced installed extensions cannot be overwritten manually. 63 // Forced installed extensions cannot be overwritten manually.
64 if (extension->location() != Manifest::EXTERNAL_POLICY_DOWNLOAD && 64 if (extension->location() != Manifest::EXTERNAL_POLICY &&
65 extension->location() != Manifest::EXTERNAL_POLICY_DOWNLOAD &&
65 forcelist && forcelist->HasKey(extension->id())) { 66 forcelist && forcelist->HasKey(extension->id())) {
66 return ReturnLoadError(extension, error); 67 return ReturnLoadError(extension, error);
67 } 68 }
68 69
69 // Early exit for the common case of no policy restrictions. 70 // Early exit for the common case of no policy restrictions.
70 if ((!blacklist || blacklist->empty()) && (!allowed_types)) 71 if ((!blacklist || blacklist->empty()) && (!allowed_types))
71 return true; 72 return true;
72 73
73 // Check whether the extension type is allowed. 74 // Check whether the extension type is allowed.
74 // 75 //
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 bool UserMayModifySettings(const Extension* extension, string16* error) { 112 bool UserMayModifySettings(const Extension* extension, string16* error) {
112 return ManagementPolicyImpl(extension, error, true); 113 return ManagementPolicyImpl(extension, error, true);
113 } 114 }
114 115
115 bool MustRemainEnabled(const Extension* extension, string16* error) { 116 bool MustRemainEnabled(const Extension* extension, string16* error) {
116 return ManagementPolicyImpl(extension, error, false); 117 return ManagementPolicyImpl(extension, error, false);
117 } 118 }
118 119
119 } // namespace admin_policy 120 } // namespace admin_policy
120 } // namespace extensions 121 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/enterprise_extension_observer.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698