Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4511)

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 24365004: Add EXTERNAL_POLICY to list of possible extension locations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/admin_policy.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index c763b9e4d594daa1338f9951567d2e04c5a08a6f..a8c01bc05c1bc6d0d615317752cd518bf9adb3a9 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -12,6 +12,7 @@
#include "base/bind.h"
#include "base/json/json_writer.h"
#include "base/lazy_instance.h"
+#include "base/logging.h"
#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
#include "base/metrics/histogram.h"
@@ -190,10 +191,14 @@ scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(
case Manifest::EXTERNAL_PREF_DOWNLOAD:
info->install_type = management::ExtensionInfo::INSTALL_TYPE_SIDELOAD;
break;
+ case Manifest::EXTERNAL_POLICY:
case Manifest::EXTERNAL_POLICY_DOWNLOAD:
info->install_type = management::ExtensionInfo::INSTALL_TYPE_ADMIN;
break;
- default:
+ case Manifest::NUM_LOCATIONS:
+ NOTREACHED();
+ case Manifest::INVALID_LOCATION:
+ case Manifest::COMPONENT:
info->install_type = management::ExtensionInfo::INSTALL_TYPE_OTHER;
break;
}
« no previous file with comments | « chrome/browser/extensions/admin_policy.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698