Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2435533004: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser/signin (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asanka, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser/signin Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160 Cr-Commit-Position: refs/heads/master@{#426951}

Patch Set 1 #

Patch Set 2 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M chrome/browser/download/download_history.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/signin/cross_device_promo.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/status_icons/status_icon.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Eric Willigers
4 years, 2 months ago (2016-10-19 12:07:30 UTC) #4
Andrew T Wilson (Slow)
lgtm
4 years, 2 months ago (2016-10-21 13:39:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435533004/20001
4 years, 2 months ago (2016-10-21 21:00:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287196)
4 years, 2 months ago (2016-10-21 21:42:07 UTC) #11
Eric Willigers
4 years, 2 months ago (2016-10-21 23:07:14 UTC) #13
Lei Zhang
rs lgtm
4 years, 2 months ago (2016-10-22 00:38:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435533004/20001
4 years, 2 months ago (2016-10-22 01:13:08 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 02:20:05 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 02:22:16 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160
Cr-Commit-Position: refs/heads/master@{#426951}

Powered by Google App Engine
This is Rietveld 408576698