Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: chrome/browser/signin/cross_device_promo.cc

Issue 2435533004: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser/signin (Closed)
Patch Set: braces Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_history.cc ('k') | chrome/browser/signin/easy_unlock_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/cross_device_promo.cc
diff --git a/chrome/browser/signin/cross_device_promo.cc b/chrome/browser/signin/cross_device_promo.cc
index c1e3326d9a2d5508cd33855df88267c92f6a5c1e..889b75da0e3ad6a809185a57bbca351c8db24efd 100644
--- a/chrome/browser/signin/cross_device_promo.cc
+++ b/chrome/browser/signin/cross_device_promo.cc
@@ -283,8 +283,8 @@ void CrossDevicePromo::MarkPromoShouldBeShown() {
if (!prefs_->GetBoolean(prefs::kCrossDevicePromoShouldBeShown)) {
prefs_->SetBoolean(prefs::kCrossDevicePromoShouldBeShown, true);
- FOR_EACH_OBSERVER(CrossDevicePromo::Observer, observer_list_,
- OnPromoEligibilityChanged(true));
+ for (CrossDevicePromo::Observer& observer : observer_list_)
+ observer.OnPromoEligibilityChanged(true);
}
}
@@ -292,8 +292,8 @@ void CrossDevicePromo::MarkPromoShouldNotBeShown() {
VLOG(1) << "CrossDevicePromo::MarkPromoShouldNotBeShown.";
if (prefs_->GetBoolean(prefs::kCrossDevicePromoShouldBeShown)) {
prefs_->SetBoolean(prefs::kCrossDevicePromoShouldBeShown, false);
- FOR_EACH_OBSERVER(CrossDevicePromo::Observer, observer_list_,
- OnPromoEligibilityChanged(false));
+ for (CrossDevicePromo::Observer& observer : observer_list_)
+ observer.OnPromoEligibilityChanged(false);
}
}
« no previous file with comments | « chrome/browser/download/download_history.cc ('k') | chrome/browser/signin/easy_unlock_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698