Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2665)

Unified Diff: chrome/browser/signin/signin_manager_factory.cc

Issue 2435533004: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser/signin (Closed)
Patch Set: braces Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/easy_unlock_service.cc ('k') | chrome/browser/status_icons/status_icon.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager_factory.cc
diff --git a/chrome/browser/signin/signin_manager_factory.cc b/chrome/browser/signin/signin_manager_factory.cc
index 96856204292365b089c3f6396f3f8fc57089a039..10f458d7a3c6c1735c1bb8df5bf2a1324015e233 100644
--- a/chrome/browser/signin/signin_manager_factory.cc
+++ b/chrome/browser/signin/signin_manager_factory.cc
@@ -100,7 +100,8 @@ void SigninManagerFactory::RemoveObserver(Observer* observer) {
void SigninManagerFactory::NotifyObserversOfSigninManagerCreationForTesting(
SigninManagerBase* manager) {
- FOR_EACH_OBSERVER(Observer, observer_list_, SigninManagerCreated(manager));
+ for (Observer& observer : observer_list_)
+ observer.SigninManagerCreated(manager);
}
KeyedService* SigninManagerFactory::BuildServiceInstanceFor(
@@ -122,7 +123,8 @@ KeyedService* SigninManagerFactory::BuildServiceInstanceFor(
AccountFetcherServiceFactory::GetForProfile(profile);
#endif
service->Initialize(g_browser_process->local_state());
- FOR_EACH_OBSERVER(Observer, observer_list_, SigninManagerCreated(service));
+ for (Observer& observer : observer_list_)
+ observer.SigninManagerCreated(service);
return service;
}
@@ -130,7 +132,9 @@ void SigninManagerFactory::BrowserContextShutdown(
content::BrowserContext* context) {
SigninManagerBase* manager = static_cast<SigninManagerBase*>(
GetServiceForBrowserContext(context, false));
- if (manager)
- FOR_EACH_OBSERVER(Observer, observer_list_, SigninManagerShutdown(manager));
+ if (manager) {
+ for (Observer& observer : observer_list_)
+ observer.SigninManagerShutdown(manager);
+ }
BrowserContextKeyedServiceFactory::BrowserContextShutdown(context);
}
« no previous file with comments | « chrome/browser/signin/easy_unlock_service.cc ('k') | chrome/browser/status_icons/status_icon.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698