Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2435193003: Mus: surfaces::CompositorFrameSink => DisplayCompositorFrameSink (Closed)

Created:
4 years, 2 months ago by Fady Samuel
Modified:
4 years, 2 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: surfaces::CompositorFrameSink => DisplayCompositorFrameSink BUG=656975 Committed: https://crrev.com/25dbbfb015586119024b310621878990703345f3 Cr-Commit-Position: refs/heads/master@{#426881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -256 lines) Patch
M services/ui/surfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D services/ui/surfaces/compositor_frame_sink.h View 1 chunk +0 lines, -80 lines 0 comments Download
D services/ui/surfaces/compositor_frame_sink.cc View 1 chunk +0 lines, -137 lines 0 comments Download
A + services/ui/surfaces/display_compositor_frame_sink.h View 3 chunks +14 lines, -16 lines 0 comments Download
A + services/ui/surfaces/display_compositor_frame_sink.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M services/ui/ws/frame_generator.h View 2 chunks +2 lines, -5 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M services/ui/ws/platform_display.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Fady Samuel
PTAL Rob!
4 years, 2 months ago (2016-10-21 18:01:46 UTC) #2
rjkroege
lgtm
4 years, 2 months ago (2016-10-21 18:08:38 UTC) #3
Fady Samuel
+sky@ for services/ui/ws
4 years, 2 months ago (2016-10-21 18:09:29 UTC) #5
sky
LGTM
4 years, 2 months ago (2016-10-21 20:09:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435193003/1
4 years, 2 months ago (2016-10-21 20:19:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 20:44:21 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 20:46:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25dbbfb015586119024b310621878990703345f3
Cr-Commit-Position: refs/heads/master@{#426881}

Powered by Google App Engine
This is Rietveld 408576698