Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2435013002: Revert of [inspector] align console implementation with spec (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] align console implementation with spec (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428473003/ ) Reason for revert: Breaks roll: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164610 See https://chromiumcodereview.appspot.com/2434733002/ for more context Original issue's description: > [inspector] align console implementation with spec > > console should be non enumerable. > > BUG=chromium:656826 > R=dgozman@chromium.org TBR=dgozman@chromium.org,kozyatinskiy@chromium.org NOTRY=true BUG=chromium:656826 Committed: https://crrev.com/555a725810cae5195a770f0fd6e83b09aff06414 Cr-Commit-Position: refs/heads/master@{#40464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -70 lines) Patch
M src/inspector/inspected-context.cc View 1 chunk +3 lines, -5 lines 0 comments Download
D test/inspector/console/console-follow-spec.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/inspector/console/console-follow-spec-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Hablich
Created Revert of [inspector] align console implementation with spec
4 years, 2 months ago (2016-10-20 11:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435013002/1
4 years, 2 months ago (2016-10-20 11:49:08 UTC) #3
Michael Achenbach
LGTM - maybe add NOTRY as we don't test that on the V8 side yet ...
4 years, 2 months ago (2016-10-20 11:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435013002/1
4 years, 2 months ago (2016-10-20 11:54:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 11:57:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/555a725810cae5195a770f0fd6e83b09aff06414
Cr-Commit-Position: refs/heads/master@{#40464}

Powered by Google App Engine
This is Rietveld 408576698