Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2428473003: [inspector] align console implementation with spec (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] align console implementation with spec console should be non enumerable. BUG=chromium:656826 R=dgozman@chromium.org Committed: https://crrev.com/550910445fed4d75e346f21e27f23fff040ab3c3 Cr-Commit-Position: refs/heads/master@{#40414}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3 lines) Patch
M src/inspector/inspected-context.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
A test/inspector/console/console-follow-spec.js View 1 chunk +49 lines, -0 lines 0 comments Download
A test/inspector/console/console-follow-spec-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-10-17 23:59:20 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2428473003/diff/1/src/inspector/inspected-context.cc File src/inspector/inspected-context.cc (right): https://codereview.chromium.org/2428473003/diff/1/src/inspector/inspected-context.cc#newcode55 src/inspector/inspected-context.cc:55: ->DefineProperty(info.context, What is this formatting?
4 years, 2 months ago (2016-10-19 00:19:53 UTC) #2
kozy
thanks! all done. https://codereview.chromium.org/2428473003/diff/1/src/inspector/inspected-context.cc File src/inspector/inspected-context.cc (right): https://codereview.chromium.org/2428473003/diff/1/src/inspector/inspected-context.cc#newcode55 src/inspector/inspected-context.cc:55: ->DefineProperty(info.context, On 2016/10/19 00:19:53, dgozman wrote: ...
4 years, 2 months ago (2016-10-19 00:54:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428473003/20001
4 years, 2 months ago (2016-10-19 01:31:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 02:02:01 UTC) #7
Michael Hablich
A revert of this CL (patchset #2 id:20001) has been created in https://chromiumcodereview.appspot.com/2435013002/ by hablich@chromium.org. ...
4 years, 2 months ago (2016-10-20 11:49:04 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:26 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/550910445fed4d75e346f21e27f23fff040ab3c3
Cr-Commit-Position: refs/heads/master@{#40414}

Powered by Google App Engine
This is Rietveld 408576698