Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24348002: Migrate DBus service constants from flimflam namespace to shill namespace. (Closed)

Created:
7 years, 3 months ago by Ben Chan
Modified:
7 years, 3 months ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebased to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -580 lines) Patch
M chromeos/network/client_cert_resolver_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/network/client_cert_util.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M chromeos/network/device_state.cc View 5 chunks +22 lines, -22 lines 0 comments Download
M chromeos/network/favorite_state.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/geolocation_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/network/geolocation_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chromeos/network/managed_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/managed_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_cert_migrator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chromeos/network/network_change_notifier_chromeos_unittest.cc View 7 chunks +24 lines, -24 lines 0 comments Download
M chromeos/network/network_configuration_handler.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 9 chunks +22 lines, -25 lines 0 comments Download
M chromeos/network/network_connection_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 11 chunks +27 lines, -30 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_device_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chromeos/network/network_device_handler_unittest.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M chromeos/network/network_profile_handler.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chromeos/network/network_sms_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state.cc View 10 chunks +46 lines, -47 lines 0 comments Download
M chromeos/network/network_state_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state_handler.cc View 7 chunks +16 lines, -17 lines 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 11 chunks +23 lines, -23 lines 0 comments Download
M chromeos/network/network_state_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chromeos/network/network_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/network/network_util_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 3 chunks +101 lines, -101 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/policy_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler.cc View 10 chunks +16 lines, -20 lines 0 comments Download
M chromeos/network/shill_property_handler_unittest.cc View 10 chunks +74 lines, -81 lines 0 comments Download
M chromeos/network/shill_property_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_util.cc View 6 chunks +25 lines, -27 lines 0 comments Download
M chromeos/network/shill_property_util_unittest.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ben Chan
7 years, 3 months ago (2013-09-22 20:50:08 UTC) #1
Ben Chan
7 years, 3 months ago (2013-09-23 05:02:53 UTC) #2
Ben Chan
7 years, 3 months ago (2013-09-23 17:07:15 UTC) #3
stevenjb
lgtm
7 years, 3 months ago (2013-09-23 17:29:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/24348002/1
7 years, 3 months ago (2013-09-23 17:34:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=79512
7 years, 3 months ago (2013-09-23 19:06:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/24348002/10001
7 years, 3 months ago (2013-09-23 19:29:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/24348002/10001
7 years, 3 months ago (2013-09-23 21:00:16 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 07:24:57 UTC) #9
Message was sent while issue was closed. 
Change committed as 224942

Powered by Google App Engine
This is Rietveld 408576698