Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chromeos/network/network_cert_migrator_unittest.cc

Issue 24348002: Migrate DBus service constants from flimflam namespace to shill namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased to ToT Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/network_cert_migrator.h" 5 #include "chromeos/network/network_cert_migrator.h"
6 6
7 #include <cert.h> 7 #include <cert.h>
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 network_state_handler_.reset(NetworkStateHandler::InitializeForTest()); 97 network_state_handler_.reset(NetworkStateHandler::InitializeForTest());
98 network_cert_migrator_.reset(new NetworkCertMigrator); 98 network_cert_migrator_.reset(new NetworkCertMigrator);
99 network_cert_migrator_->Init(network_state_handler_.get()); 99 network_cert_migrator_->Init(network_state_handler_.get());
100 } 100 }
101 101
102 void SetupWifiWithNss() { 102 void SetupWifiWithNss() {
103 const bool add_to_visible = true; 103 const bool add_to_visible = true;
104 const bool add_to_watchlist = true; 104 const bool add_to_watchlist = true;
105 service_test_->AddService(kWifiStub, 105 service_test_->AddService(kWifiStub,
106 kWifiStub, 106 kWifiStub,
107 flimflam::kTypeWifi, 107 shill::kTypeWifi,
108 flimflam::kStateOnline, 108 shill::kStateOnline,
109 add_to_visible, 109 add_to_visible,
110 add_to_watchlist); 110 add_to_watchlist);
111 service_test_->SetServiceProperty(kWifiStub, 111 service_test_->SetServiceProperty(kWifiStub,
112 flimflam::kEapCaCertNssProperty, 112 shill::kEapCaCertNssProperty,
113 base::StringValue(kNSSNickname)); 113 base::StringValue(kNSSNickname));
114 } 114 }
115 115
116 void GetEapCACertProperties(std::string* nss_nickname, std::string* ca_pem) { 116 void GetEapCACertProperties(std::string* nss_nickname, std::string* ca_pem) {
117 nss_nickname->clear(); 117 nss_nickname->clear();
118 ca_pem->clear(); 118 ca_pem->clear();
119 const base::DictionaryValue* properties = 119 const base::DictionaryValue* properties =
120 service_test_->GetServiceProperties(kWifiStub); 120 service_test_->GetServiceProperties(kWifiStub);
121 properties->GetStringWithoutPathExpansion(flimflam::kEapCaCertNssProperty, 121 properties->GetStringWithoutPathExpansion(shill::kEapCaCertNssProperty,
122 nss_nickname); 122 nss_nickname);
123 const base::ListValue* ca_pems = NULL; 123 const base::ListValue* ca_pems = NULL;
124 properties->GetListWithoutPathExpansion(shill::kEapCaCertPemProperty, 124 properties->GetListWithoutPathExpansion(shill::kEapCaCertPemProperty,
125 &ca_pems); 125 &ca_pems);
126 if (ca_pems && !ca_pems->empty()) 126 if (ca_pems && !ca_pems->empty())
127 ca_pems->GetString(0, ca_pem); 127 ca_pems->GetString(0, ca_pem);
128 } 128 }
129 129
130 void SetupVpnWithNss(bool open_vpn) { 130 void SetupVpnWithNss(bool open_vpn) {
131 const bool add_to_visible = true; 131 const bool add_to_visible = true;
132 const bool add_to_watchlist = true; 132 const bool add_to_watchlist = true;
133 service_test_->AddService(kVPNStub, 133 service_test_->AddService(kVPNStub,
134 kVPNStub, 134 kVPNStub,
135 flimflam::kTypeVPN, 135 shill::kTypeVPN,
136 flimflam::kStateIdle, 136 shill::kStateIdle,
137 add_to_visible, 137 add_to_visible,
138 add_to_watchlist); 138 add_to_watchlist);
139 base::DictionaryValue provider; 139 base::DictionaryValue provider;
140 const char* nss_property = open_vpn ? flimflam::kOpenVPNCaCertNSSProperty 140 const char* nss_property = open_vpn ? shill::kOpenVPNCaCertNSSProperty
141 : flimflam::kL2tpIpsecCaCertNssProperty; 141 : shill::kL2tpIpsecCaCertNssProperty;
142 provider.SetStringWithoutPathExpansion(nss_property, kNSSNickname); 142 provider.SetStringWithoutPathExpansion(nss_property, kNSSNickname);
143 service_test_->SetServiceProperty( 143 service_test_->SetServiceProperty(
144 kVPNStub, flimflam::kProviderProperty, provider); 144 kVPNStub, shill::kProviderProperty, provider);
145 } 145 }
146 146
147 void GetVpnCACertProperties(bool open_vpn, 147 void GetVpnCACertProperties(bool open_vpn,
148 std::string* nss_nickname, 148 std::string* nss_nickname,
149 std::string* ca_pem) { 149 std::string* ca_pem) {
150 nss_nickname->clear(); 150 nss_nickname->clear();
151 ca_pem->clear(); 151 ca_pem->clear();
152 const base::DictionaryValue* properties = 152 const base::DictionaryValue* properties =
153 service_test_->GetServiceProperties(kVPNStub); 153 service_test_->GetServiceProperties(kVPNStub);
154 const base::DictionaryValue* provider = NULL; 154 const base::DictionaryValue* provider = NULL;
155 properties->GetDictionaryWithoutPathExpansion(flimflam::kProviderProperty, 155 properties->GetDictionaryWithoutPathExpansion(shill::kProviderProperty,
156 &provider); 156 &provider);
157 if (!provider) 157 if (!provider)
158 return; 158 return;
159 const char* nss_property = open_vpn ? flimflam::kOpenVPNCaCertNSSProperty 159 const char* nss_property = open_vpn ? shill::kOpenVPNCaCertNSSProperty
160 : flimflam::kL2tpIpsecCaCertNssProperty; 160 : shill::kL2tpIpsecCaCertNssProperty;
161 provider->GetStringWithoutPathExpansion(nss_property, nss_nickname); 161 provider->GetStringWithoutPathExpansion(nss_property, nss_nickname);
162 const base::ListValue* ca_pems = NULL; 162 const base::ListValue* ca_pems = NULL;
163 const char* pem_property = open_vpn ? shill::kOpenVPNCaCertPemProperty 163 const char* pem_property = open_vpn ? shill::kOpenVPNCaCertPemProperty
164 : shill::kL2tpIpsecCaCertPemProperty; 164 : shill::kL2tpIpsecCaCertPemProperty;
165 provider->GetListWithoutPathExpansion(pem_property, &ca_pems); 165 provider->GetListWithoutPathExpansion(pem_property, &ca_pems);
166 if (ca_pems && !ca_pems->empty()) 166 if (ca_pems && !ca_pems->empty())
167 ca_pems->GetString(0, ca_pem); 167 ca_pems->GetString(0, ca_pem);
168 } 168 }
169 169
170 ShillServiceClient::TestInterface* service_test_; 170 ShillServiceClient::TestInterface* service_test_;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 255
256 message_loop_.RunUntilIdle(); 256 message_loop_.RunUntilIdle();
257 std::string nss_nickname, ca_pem; 257 std::string nss_nickname, ca_pem;
258 GetVpnCACertProperties(false /* not OpenVPN */, &nss_nickname, &ca_pem); 258 GetVpnCACertProperties(false /* not OpenVPN */, &nss_nickname, &ca_pem);
259 EXPECT_TRUE(nss_nickname.empty()); 259 EXPECT_TRUE(nss_nickname.empty());
260 EXPECT_EQ(test_ca_cert_pem_, ca_pem); 260 EXPECT_EQ(test_ca_cert_pem_, ca_pem);
261 } 261 }
262 262
263 263
264 } // namespace chromeos 264 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/network/network_cert_migrator.cc ('k') | chromeos/network/network_change_notifier_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698