Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: chromeos/network/favorite_state.cc

Issue 24348002: Migrate DBus service constants from flimflam namespace to shill namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased to ToT Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/network/device_state.cc ('k') | chromeos/network/geolocation_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/favorite_state.h" 5 #include "chromeos/network/favorite_state.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chromeos/network/network_event_log.h" 10 #include "chromeos/network/network_event_log.h"
11 #include "chromeos/network/network_profile_handler.h" 11 #include "chromeos/network/network_profile_handler.h"
12 #include "chromeos/network/network_state.h" 12 #include "chromeos/network/network_state.h"
13 #include "chromeos/network/shill_property_util.h" 13 #include "chromeos/network/shill_property_util.h"
14 #include "third_party/cros_system_api/dbus/service_constants.h" 14 #include "third_party/cros_system_api/dbus/service_constants.h"
15 15
16 namespace chromeos { 16 namespace chromeos {
17 17
18 FavoriteState::FavoriteState(const std::string& path) 18 FavoriteState::FavoriteState(const std::string& path)
19 : ManagedState(MANAGED_TYPE_FAVORITE, path) { 19 : ManagedState(MANAGED_TYPE_FAVORITE, path) {
20 } 20 }
21 21
22 FavoriteState::~FavoriteState() { 22 FavoriteState::~FavoriteState() {
23 } 23 }
24 24
25 bool FavoriteState::PropertyChanged(const std::string& key, 25 bool FavoriteState::PropertyChanged(const std::string& key,
26 const base::Value& value) { 26 const base::Value& value) {
27 if (ManagedStatePropertyChanged(key, value)) 27 if (ManagedStatePropertyChanged(key, value))
28 return true; 28 return true;
29 if (key == flimflam::kProfileProperty) { 29 if (key == shill::kProfileProperty) {
30 return GetStringValue(key, value, &profile_path_); 30 return GetStringValue(key, value, &profile_path_);
31 } else if (key == flimflam::kUIDataProperty) { 31 } else if (key == shill::kUIDataProperty) {
32 scoped_ptr<NetworkUIData> new_ui_data = 32 scoped_ptr<NetworkUIData> new_ui_data =
33 shill_property_util::GetUIDataFromValue(value); 33 shill_property_util::GetUIDataFromValue(value);
34 if (!new_ui_data) { 34 if (!new_ui_data) {
35 NET_LOG_ERROR("Failed to parse " + key, path()); 35 NET_LOG_ERROR("Failed to parse " + key, path());
36 return false; 36 return false;
37 } 37 }
38 ui_data_ = *new_ui_data; 38 ui_data_ = *new_ui_data;
39 return true; 39 return true;
40 } else if (key == flimflam::kGuidProperty) { 40 } else if (key == shill::kGuidProperty) {
41 return GetStringValue(key, value, &guid_); 41 return GetStringValue(key, value, &guid_);
42 } 42 }
43 return false; 43 return false;
44 } 44 }
45 45
46 bool FavoriteState::IsManaged() const { 46 bool FavoriteState::IsManaged() const {
47 return ui_data_.onc_source() == onc::ONC_SOURCE_DEVICE_POLICY || 47 return ui_data_.onc_source() == onc::ONC_SOURCE_DEVICE_POLICY ||
48 ui_data_.onc_source() == onc::ONC_SOURCE_USER_POLICY; 48 ui_data_.onc_source() == onc::ONC_SOURCE_USER_POLICY;
49 } 49 }
50 50
51 bool FavoriteState::IsPrivate() const { 51 bool FavoriteState::IsPrivate() const {
52 return !profile_path_.empty() && 52 return !profile_path_.empty() &&
53 profile_path_ != NetworkProfileHandler::kSharedProfilePath; 53 profile_path_ != NetworkProfileHandler::kSharedProfilePath;
54 } 54 }
55 55
56 } // namespace chromeos 56 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/network/device_state.cc ('k') | chromeos/network/geolocation_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698