Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2433133002: Remove IFWL_*::Create methods, use new (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFWL_*::Create methods, use new The create methods just proxied to the constructor. Remove Creates and call new directly where needed. Committed: https://pdfium.googlesource.com/pdfium/+/2a38a02b0492de0576c2e5b5e7d550f969367f9d

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -236 lines) Patch
M xfa/fwl/core/ifwl_barcode.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_caret.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_caret.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.h View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 1 chunk +1 line, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 1 6 chunks +9 lines, -15 lines 0 comments Download
M xfa/fwl/core/ifwl_comboedit.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_comboedit.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_combolist.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_combolist.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimecalendar.h View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimecalendar.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 1 7 chunks +13 lines, -16 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 1 3 chunks +2 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.h View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.h View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.h View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_barcode.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_checkbox.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_picturebox.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_pushbutton.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2435603003 Patch 20001

Messages

Total messages: 17 (11 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-19 16:09:29 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/2433133002/diff/1/xfa/fwl/lightwidget/cfwl_barcode.cpp File xfa/fwl/lightwidget/cfwl_barcode.cpp (right): https://codereview.chromium.org/2433133002/diff/1/xfa/fwl/lightwidget/cfwl_barcode.cpp#newcode28 xfa/fwl/lightwidget/cfwl_barcode.cpp:28: m_pProperties->MakeWidgetImpProperties(&m_barcodeData)); Nit, is this a bit simpler? std::unique_ptr<IFWL_Barcode> ...
4 years, 2 months ago (2016-10-19 17:13:07 UTC) #3
dsinclair
https://codereview.chromium.org/2433133002/diff/1/xfa/fwl/lightwidget/cfwl_barcode.cpp File xfa/fwl/lightwidget/cfwl_barcode.cpp (right): https://codereview.chromium.org/2433133002/diff/1/xfa/fwl/lightwidget/cfwl_barcode.cpp#newcode28 xfa/fwl/lightwidget/cfwl_barcode.cpp:28: m_pProperties->MakeWidgetImpProperties(&m_barcodeData)); On 2016/10/19 17:13:07, Wei Li wrote: > Nit, ...
4 years, 2 months ago (2016-10-19 17:21:28 UTC) #4
Wei Li
rs lgtm
4 years, 2 months ago (2016-10-19 19:01:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433133002/60001
4 years, 2 months ago (2016-10-20 13:47:43 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 14:07:52 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/2a38a02b0492de0576c2e5b5e7d550f96936...

Powered by Google App Engine
This is Rietveld 408576698