xfa/fwl/lightwidget/cfwl_combobox.cpp - Issue 2433133002: Remove IFWL_*::Create methods, use new

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/lightwidget/cfwl_combobox.cpp

Issue 2433133002: Remove IFWL_*::Create methods, use new (Closed)

Patch Set: Rebase to master Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/lightwidget/cfwl_combobox.cpp

diff --git a/xfa/fwl/lightwidget/cfwl_combobox.cpp b/xfa/fwl/lightwidget/cfwl_combobox.cpp

index 9c4cd05e57bd1bb5a0fce0367b0cb252581288be..a56b875907cafaad9d011a5f2bc402411155d0e9 100644

--- a/xfa/fwl/lightwidget/cfwl_combobox.cpp

+++ b/xfa/fwl/lightwidget/cfwl_combobox.cpp

@@ -25,7 +25,7 @@ FWL_Error CFWL_ComboBox::Initialize(const CFWL_WidgetProperties* pProperties) {

if (pProperties) {

*m_pProperties = *pProperties;

}

- std::unique_ptr<IFWL_ComboBox> pComboBox(IFWL_ComboBox::Create(

+ std::unique_ptr<IFWL_ComboBox> pComboBox(new IFWL_ComboBox(

m_pProperties->MakeWidgetImpProperties(&m_comboBoxData)));

FWL_Error ret = pComboBox->Initialize();

if (ret != FWL_Error::Succeeded) {

« no previous file with comments | « xfa/fwl/lightwidget/cfwl_checkbox.cpp ('k') | xfa/fwl/lightwidget/cfwl_datetimepicker.cpp » ('j') | no next file with comments »