Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2435603003: Cleanup unused methods and return values in FWL code. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup unused methods and return values in FWL code. This CL does an initial pass to remove unused methods and return values in the FWL code base. Committed: https://pdfium.googlesource.com/pdfium/+/73895de7dea3737d1a25801001b8efe186c6f5a3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to master #

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -774 lines) Patch
M xfa/fwl/core/cfwl_event.h View 3 chunks +0 lines, -10 lines 0 comments Download
M xfa/fwl/core/cfwl_message.h View 4 chunks +0 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_caret.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_caret.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_combolist.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_combolist.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimecalendar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimecalendar.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 2 chunks +6 lines, -13 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 3 chunks +11 lines, -13 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_form.cpp View 1 3 chunks +5 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.h View 3 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_themeprovider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 3 chunks +12 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 3 chunks +17 lines, -28 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.h View 1 chunk +11 lines, -33 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.cpp View 5 chunks +21 lines, -216 lines 0 comments Download
M xfa/fwl/theme/cfwl_barcodetp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_barcodetp.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_carettp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_carettp.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M xfa/fwl/theme/cfwl_comboboxtp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_comboboxtp.cpp View 1 2 4 chunks +10 lines, -6 lines 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickertp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickertp.cpp View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.cpp View 3 chunks +14 lines, -13 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.h View 2 chunks +13 lines, -13 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 13 chunks +44 lines, -41 lines 0 comments Download
M xfa/fwl/theme/cfwl_pictureboxtp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_pictureboxtp.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.cpp View 4 chunks +13 lines, -7 lines 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.cpp View 1 2 9 chunks +21 lines, -13 lines 0 comments Download
M xfa/fwl/theme/cfwl_utils.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 2 chunks +19 lines, -20 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 5 chunks +27 lines, -49 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 1 chunk +5 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 10 chunks +35 lines, -42 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-19 19:06:36 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/2435603003/diff/1/xfa/fwl/theme/cfwl_scrollbartp.cpp File xfa/fwl/theme/cfwl_scrollbartp.cpp (right): https://codereview.chromium.org/2435603003/diff/1/xfa/fwl/theme/cfwl_scrollbartp.cpp#newcode223 xfa/fwl/theme/cfwl_scrollbartp.cpp:223: if (eState < FWLTHEME_STATE_Normal || eState > FWLTHEME_STATE_Disabale) ...
4 years, 2 months ago (2016-10-20 00:18:57 UTC) #7
dsinclair
https://codereview.chromium.org/2435603003/diff/1/xfa/fwl/theme/cfwl_scrollbartp.cpp File xfa/fwl/theme/cfwl_scrollbartp.cpp (right): https://codereview.chromium.org/2435603003/diff/1/xfa/fwl/theme/cfwl_scrollbartp.cpp#newcode223 xfa/fwl/theme/cfwl_scrollbartp.cpp:223: if (eState < FWLTHEME_STATE_Normal || eState > FWLTHEME_STATE_Disabale) On ...
4 years, 2 months ago (2016-10-20 14:11:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435603003/40001
4 years, 2 months ago (2016-10-20 14:11:55 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 14:19:46 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/73895de7dea3737d1a25801001b8efe186c6...

Powered by Google App Engine
This is Rietveld 408576698