Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2432883002: Replaced PassRefPtr copies with moves in unit tests. (Closed)

Created:
4 years, 2 months ago by Bugs Nash
Modified:
4 years, 2 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced PassRefPtr copies with moves in unit tests. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG=640449 Committed: https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a Cr-Commit-Position: refs/heads/master@{#426269}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
Bugs Nash
This fixes the errors found from running webkit_unit_tests and blink_platform_unittests. I believe that is exhaustive ...
4 years, 2 months ago (2016-10-19 04:33:07 UTC) #4
Yuta Kitamura
lgtm
4 years, 2 months ago (2016-10-19 06:07:55 UTC) #5
haraken
LGTM
4 years, 2 months ago (2016-10-19 08:39:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432883002/1
4 years, 2 months ago (2016-10-19 20:17:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 20:28:09 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2743001ba2a1d60bcac4f1690b3cfbd86d92b0a
Cr-Commit-Position: refs/heads/master@{#426269}

Powered by Google App Engine
This is Rietveld 408576698