third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp - Issue 2432883002: Replaced PassRefPtr copies with moves in unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp

Issue 2432883002: Replaced PassRefPtr copies with moves in unit tests. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h ('k') | third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp

index e6e2ef88d7c69692ab946b544e636f08aeb02ad1..ea13c9fab03ce2d04e052138b7754d719a50428d 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp

@@ -48,7 +48,7 @@ TEST(FetchDataLoaderTest, LoadAsBlob) {

EXPECT_CALL(*consumer,

drainAsBlobDataHandle(

BytesConsumer::BlobSizePolicy::DisallowBlobWithInvalidSize))

- .WillOnce(Return(nullptr));

+ .WillOnce(Return(ByMove(nullptr)));

EXPECT_CALL(*consumer, setClient(_)).WillOnce(SaveArg<0>(&client));

EXPECT_CALL(*consumer, beginRead(_, _))

.WillOnce(DoAll(SetArgPointee<0>(nullptr), SetArgPointee<1>(0),

@@ -96,7 +96,7 @@ TEST(FetchDataLoaderTest, LoadAsBlobFailed) {

EXPECT_CALL(*consumer,

drainAsBlobDataHandle(

BytesConsumer::BlobSizePolicy::DisallowBlobWithInvalidSize))

- .WillOnce(Return(nullptr));

+ .WillOnce(Return(ByMove(nullptr)));

EXPECT_CALL(*consumer, setClient(_)).WillOnce(SaveArg<0>(&client));

EXPECT_CALL(*consumer, beginRead(_, _))

.WillOnce(DoAll(SetArgPointee<0>(nullptr), SetArgPointee<1>(0),

@@ -139,7 +139,7 @@ TEST(FetchDataLoaderTest, LoadAsBlobCancel) {

EXPECT_CALL(*consumer,

drainAsBlobDataHandle(

BytesConsumer::BlobSizePolicy::DisallowBlobWithInvalidSize))

- .WillOnce(Return(nullptr));

+ .WillOnce(Return(ByMove(nullptr)));

EXPECT_CALL(*consumer, setClient(_)).WillOnce(SaveArg<0>(&client));

EXPECT_CALL(*consumer, beginRead(_, _))

.WillOnce(DoAll(SetArgPointee<0>(nullptr), SetArgPointee<1>(0),

@@ -178,7 +178,7 @@ TEST(FetchDataLoaderTest,

EXPECT_CALL(*consumer,

drainAsBlobDataHandle(

BytesConsumer::BlobSizePolicy::DisallowBlobWithInvalidSize))

- .WillOnce(Return(inputBlobDataHandle));

+ .WillOnce(Return(ByMove(inputBlobDataHandle)));

EXPECT_CALL(*fetchDataLoaderClient, didFetchDataLoadedBlobHandleMock(_))

.WillOnce(SaveArg<0>(&blobDataHandle));

EXPECT_CALL(checkpoint, Call(2));

@@ -220,7 +220,7 @@ TEST(FetchDataLoaderTest,

EXPECT_CALL(*consumer,

drainAsBlobDataHandle(

BytesConsumer::BlobSizePolicy::DisallowBlobWithInvalidSize))

- .WillOnce(Return(inputBlobDataHandle));

+ .WillOnce(Return(ByMove(inputBlobDataHandle)));

EXPECT_CALL(*fetchDataLoaderClient, didFetchDataLoadedBlobHandleMock(_))

.WillOnce(SaveArg<0>(&blobDataHandle));

EXPECT_CALL(checkpoint, Call(2));