Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

Issue 2432883002: Replaced PassRefPtr copies with moves in unit tests. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/GlyphPageTreeNodeTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 PassRefPtr<SegmentReader> copyToDataSegmentReader( 60 PassRefPtr<SegmentReader> copyToDataSegmentReader(
61 PassRefPtr<SegmentReader> input) { 61 PassRefPtr<SegmentReader> input) {
62 return SegmentReader::createFromSkData(input->getAsSkData()); 62 return SegmentReader::createFromSkData(input->getAsSkData());
63 } 63 }
64 64
65 struct SegmentReaders { 65 struct SegmentReaders {
66 RefPtr<SegmentReader> segmentReaders[3]; 66 RefPtr<SegmentReader> segmentReaders[3];
67 67
68 SegmentReaders(PassRefPtr<SharedBuffer> input) { 68 SegmentReaders(PassRefPtr<SharedBuffer> input) {
69 segmentReaders[0] = SegmentReader::createFromSharedBuffer(input); 69 segmentReaders[0] = SegmentReader::createFromSharedBuffer(std::move(input));
70 segmentReaders[1] = copyToROBufferSegmentReader(segmentReaders[0]); 70 segmentReaders[1] = copyToROBufferSegmentReader(segmentReaders[0]);
71 segmentReaders[2] = copyToDataSegmentReader(segmentReaders[0]); 71 segmentReaders[2] = copyToDataSegmentReader(segmentReaders[0]);
72 } 72 }
73 }; 73 };
74 74
75 } // namespace 75 } // namespace
76 76
77 TEST(FastSharedBufferReaderTest, nonSequentialReads) { 77 TEST(FastSharedBufferReaderTest, nonSequentialReads) {
78 char referenceData[kDefaultTestSize]; 78 char referenceData[kDefaultTestSize];
79 prepareReferenceData(referenceData, sizeof(referenceData)); 79 prepareReferenceData(referenceData, sizeof(referenceData));
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 ASSERT_NE(length, lastLength); 231 ASSERT_NE(length, lastLength);
232 lastLength = length; 232 lastLength = length;
233 233
234 ASSERT_FALSE(memcmp(segment, referenceData + position, length)); 234 ASSERT_FALSE(memcmp(segment, referenceData + position, length));
235 position += length; 235 position += length;
236 } 236 }
237 EXPECT_EQ(position, dataSize); 237 EXPECT_EQ(position, dataSize);
238 } 238 }
239 239
240 } // namespace blink 240 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/GlyphPageTreeNodeTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698