Get rid of flat tree version of createVisibleSelection() taking two PositionInFlatTree

Get rid of flat tree version of createVisibleSelection() taking two PositionInFlatTree

This patch gets rid of flat tree version of |createVisibleSelection()| taking
to |PositionInFlatTree|by replacing with |SelectionInFlatTree| version to reduce
number of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/7698389f21f877466a8e30627bead7c353b397c3
Cr-Commit-Position: refs/heads/master@{#426431}

[yosin_UTC9, 2016-10-19 09:56:00]

Description was changed from

==========
2016-10-19T18:53:52

BUG=
==========

to

==========
Get rid of flat tree version of createVisibleSelection() taking two
PositionInFlatTree

This patch gets rid of flat tree version of |createVisibleSelection()| taking
to |PositionInFlatTree|by replacing with |SelectionInFlatTree| version to reduce

number of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-19 09:56:14]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 09:57:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 14:06:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 14:06:24]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-20 04:15:10]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-20 04:15:10]

PTAL

[Xiaocheng, 2016-10-20 05:13:57]

This patch has conflict with https://codereview.chromium.org/2425623002.

Could you make this patch a depending patch?

[yosin_UTC9, 2016-10-20 05:46:42]

Patchset #2 (id:20001) has been deleted

[yosin_UTC9, 2016-10-20 05:46:48]

Patchset #2 (id:40001) has been deleted

[yosin_UTC9, 2016-10-20 05:47:13]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 05:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-20 05:47:52]

On 2016/10/20 at 05:13:57, xiaochengh wrote:
> This patch has conflict with https://codereview.chromium.org/2425623002.
> 
> Could you make this patch a depending patch?
Done. Thanks for teach me to use "branch off a branch".
Although, it seems to be complex to me. (^_^;)

[commit-bot: I haz the power, 2016-10-20 05:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 05:50:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2016-10-20 07:01:39]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 07:01:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-20 07:02:36]

On 2016/10/20 at 05:47:52, Yosi_UTC9 wrote:
> On 2016/10/20 at 05:13:57, xiaochengh wrote:
> > This patch has conflict with https://codereview.chromium.org/2425623002.
> > 
> > Could you make this patch a depending patch?
> Done. Thanks for teach me to use "branch off a branch".
> Although, it seems to be complex to me. (^_^;)
PTAL

Rebased since http://crrev.com/2425623002 was committed.

[Xiaocheng, 2016-10-20 07:44:26]

lgtm

[commit-bot: I haz the power, 2016-10-20 08:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:24:27]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-20 08:34:18]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:34:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 08:45:12]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:16:39]

Description was changed from

==========
Get rid of flat tree version of createVisibleSelection() taking two
PositionInFlatTree

This patch gets rid of flat tree version of |createVisibleSelection()| taking
to |PositionInFlatTree|by replacing with |SelectionInFlatTree| version to reduce

number of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Get rid of flat tree version of createVisibleSelection() taking two
PositionInFlatTree

This patch gets rid of flat tree version of |createVisibleSelection()| taking
to |PositionInFlatTree|by replacing with |SelectionInFlatTree| version to reduce
number of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/7698389f21f877466a8e30627bead7c353b397c3
Cr-Commit-Position: refs/heads/master@{#426431}
==========

[commit-bot: I haz the power, 2016-10-21 13:16:40]

Patchset 3 (id:??) landed as
https://crrev.com/7698389f21f877466a8e30627bead7c353b397c3
Cr-Commit-Position: refs/heads/master@{#426431}