Get rid of flat tree version of createVisibleSelection() taking two PositionInFlatTree

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Text.h"
@@ skipping 272 matching lines @@
   const char* shadowContent = "<span id=bottom>bottom</span>";
   setBodyContent(bodyContent);
   ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");
 
   Node* top = document().getElementById("top")->firstChild();
   Node* bottom = shadowRoot->getElementById("bottom")->firstChild();
   Node* host = document().getElementById("host");
 
   // top to bottom
   selection().setNonDirectionalSelectionIfNeeded(
-      createVisibleSelection(PositionInFlatTree(top, 1),
-                             PositionInFlatTree(bottom, 3)),
+      createVisibleSelection(SelectionInFlatTree::Builder()
+                                 .collapse(PositionInFlatTree(top, 1))
+                                 .extend(PositionInFlatTree(bottom, 3))
+                                 .build()),
       CharacterGranularity);
   EXPECT_EQ(Position(top, 1), visibleSelectionInDOMTree().base());
   EXPECT_EQ(Position::beforeNode(host), visibleSelectionInDOMTree().extent());
   EXPECT_EQ(Position(top, 1), visibleSelectionInDOMTree().start());
   EXPECT_EQ(Position(top, 3), visibleSelectionInDOMTree().end());
 
   EXPECT_EQ(PositionInFlatTree(top, 1), visibleSelectionInFlatTree().base());
   EXPECT_EQ(PositionInFlatTree(bottom, 3),
             visibleSelectionInFlatTree().extent());
   EXPECT_EQ(PositionInFlatTree(top, 1), visibleSelectionInFlatTree().start());
   EXPECT_EQ(PositionInFlatTree(bottom, 3), visibleSelectionInFlatTree().end());
 
   // bottom to top
   selection().setNonDirectionalSelectionIfNeeded(
-      createVisibleSelection(PositionInFlatTree(bottom, 3),
-                             PositionInFlatTree(top, 1)),
+      createVisibleSelection(SelectionInFlatTree::Builder()
+                                 .collapse(PositionInFlatTree(bottom, 3))
+                                 .extend(PositionInFlatTree(top, 1))
+                                 .build()),
       CharacterGranularity);
   EXPECT_EQ(Position(bottom, 3), visibleSelectionInDOMTree().base());
   EXPECT_EQ(Position::beforeNode(bottom->parentNode()),
             visibleSelectionInDOMTree().extent());
   EXPECT_EQ(Position(bottom, 0), visibleSelectionInDOMTree().start());
   EXPECT_EQ(Position(bottom, 3), visibleSelectionInDOMTree().end());
 
   EXPECT_EQ(PositionInFlatTree(bottom, 3), visibleSelectionInFlatTree().base());
   EXPECT_EQ(PositionInFlatTree(top, 1), visibleSelectionInFlatTree().extent());
   EXPECT_EQ(PositionInFlatTree(top, 1), visibleSelectionInFlatTree().start());
@@ skipping 27 matching lines @@
   selection().updateIfNeeded();
 
   // TODO(yosin): Once lazy canonicalization implemented, selection.start
   // should be Position(HTML, 0).
   EXPECT_EQ(Position(), selection().start())
       << "updateIfNeeded() makes selection to null.";
   EXPECT_EQ(selection().start(), caretPosition().position());
 }
 
 }  // namespace blink