Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2432383002: Get rid of flat tree version of createVisibleSelection() taking two PositionInFlatTree (Closed)
Patch Set: 2016-10-20T15:59:37 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 7bff35ae99f6747efcc4e0c4feb8d0ee8f18f826..0d7f82dd8c0198ef3f9f0cc5ab7c1cbc4d38c0b9 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -128,22 +128,6 @@ VisibleSelectionInFlatTree createVisibleSelection(
return VisibleSelectionInFlatTree::create(selection);
}
-VisibleSelectionInFlatTree createVisibleSelection(
- const PositionInFlatTree& base,
- const PositionInFlatTree& extent,
- TextAffinity affinity,
- bool isDirectional) {
- DCHECK(!needsLayoutTreeUpdate(base));
- DCHECK(!needsLayoutTreeUpdate(extent));
- // TODO(yosin): We should use |Builder::setBaseAndExtent()| once we get rid
- // of callers passing |base.istNull()| but |extent.isNotNull()|.
- SelectionInFlatTree::Builder builder;
- builder.setBaseAndExtentDeprecated(base, extent)
- .setAffinity(affinity)
- .setIsDirectional(isDirectional);
- return createVisibleSelection(builder.build());
-}
-
template <typename Strategy>
static SelectionType computeSelectionType(
const PositionTemplate<Strategy>& start,

Powered by Google App Engine
This is Rietveld 408576698