Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2431153002: Introduce FrameSelection::moveCaretSelection() as replacement of moveTo() (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 2 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce FrameSelection::moveCaretSelection() as replacement of moveTo() This patch moves an implementation of |moveCaretSelection()| to |FrameSelection| from |WebLocalFrameImpl| to make web layer thin and reduce number of usage of |VisiblePositon| for improving code health. BUG=657237 TEST=n/a; no behavior changes Committed: https://crrev.com/5f52b60a9d5f7618df1acd9319e4e04938fc38ab Cr-Commit-Position: refs/heads/master@{#426418}

Patch Set 1 : 2016-10-19T14:44:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yosin_UTC9
PTAL
4 years, 2 months ago (2016-10-20 04:14:28 UTC) #7
Xiaocheng
lgtm
4 years, 2 months ago (2016-10-20 05:22:25 UTC) #8
tkent
lgtm
4 years, 2 months ago (2016-10-20 05:30:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431153002/1
4 years, 2 months ago (2016-10-20 05:38:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 05:42:39 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f52b60a9d5f7618df1acd9319e4e04938fc38ab
Cr-Commit-Position: refs/heads/master@{#426418}

Powered by Google App Engine
This is Rietveld 408576698