Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2431153002: Introduce FrameSelection::moveCaretSelection() as replacement of moveTo() (Closed)
Patch Set: 2016-10-19T14:44:09 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index c2d3357835ce3f475d1b46707726bc9ca54812c6..4e3f3b9f1b1be87717af8dbfbb7231cd355f1872 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -111,12 +111,8 @@ class CORE_EXPORT FrameSelection final
return selection().isContentRichlyEditable();
}
- // TODO(yosin): We should make and rename |moveTo()| as implementation of
- // |WebLoalFrameImpl::moveCaretSeleciton()|, since there is only one call
- // site.
- void moveTo(const VisiblePosition&,
- EUserTriggered = NotUserTriggered,
- CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded);
+ // An implementation of |WebFrame::moveCaretSelection()|
+ void moveCaretSelection(const IntPoint&);
template <typename Strategy>
const VisibleSelectionTemplate<Strategy>& visibleSelection() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698