Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2431153002: Introduce FrameSelection::moveCaretSelection() as replacement of moveTo() (Closed)
Patch Set: 2016-10-19T14:44:09 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 } 104 }
105 Element* rootEditableElementOrDocumentElement() const; 105 Element* rootEditableElementOrDocumentElement() const;
106 ContainerNode* rootEditableElementOrTreeScopeRootNode() const; 106 ContainerNode* rootEditableElementOrTreeScopeRootNode() const;
107 107
108 bool hasEditableStyle() const { return selection().hasEditableStyle(); } 108 bool hasEditableStyle() const { return selection().hasEditableStyle(); }
109 bool isContentEditable() const { return selection().isContentEditable(); } 109 bool isContentEditable() const { return selection().isContentEditable(); }
110 bool isContentRichlyEditable() const { 110 bool isContentRichlyEditable() const {
111 return selection().isContentRichlyEditable(); 111 return selection().isContentRichlyEditable();
112 } 112 }
113 113
114 // TODO(yosin): We should make and rename |moveTo()| as implementation of 114 // An implementation of |WebFrame::moveCaretSelection()|
115 // |WebLoalFrameImpl::moveCaretSeleciton()|, since there is only one call 115 void moveCaretSelection(const IntPoint&);
116 // site.
117 void moveTo(const VisiblePosition&,
118 EUserTriggered = NotUserTriggered,
119 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded);
120 116
121 template <typename Strategy> 117 template <typename Strategy>
122 const VisibleSelectionTemplate<Strategy>& visibleSelection() const; 118 const VisibleSelectionTemplate<Strategy>& visibleSelection() const;
123 119
124 const VisibleSelection& selection() const; 120 const VisibleSelection& selection() const;
125 121
126 void setSelection(const SelectionInDOMTree&, 122 void setSelection(const SelectionInDOMTree&,
127 SetSelectionOptions = CloseTyping | ClearTypingStyle, 123 SetSelectionOptions = CloseTyping | ClearTypingStyle,
128 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, 124 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
129 TextGranularity = CharacterGranularity); 125 TextGranularity = CharacterGranularity);
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 } 385 }
390 } // namespace blink 386 } // namespace blink
391 387
392 #ifndef NDEBUG 388 #ifndef NDEBUG
393 // Outside the WebCore namespace for ease of invocation from gdb. 389 // Outside the WebCore namespace for ease of invocation from gdb.
394 void showTree(const blink::FrameSelection&); 390 void showTree(const blink::FrameSelection&);
395 void showTree(const blink::FrameSelection*); 391 void showTree(const blink::FrameSelection*);
396 #endif 392 #endif
397 393
398 #endif // FrameSelection_h 394 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698