Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2430973004: Landing Recent QUIC changes until 10:38 AM, Oct 17, 2016 UTC-4 (Closed)

Created:
4 years, 2 months ago by alyssar1
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicTestClient no longer inherit from SimpleClient Merge internal change: 136349092 https://codereview.chromium.org/2435773002/ Move FakeProofSource into its own library Merge internal change: 13620118 https://codereview.chromium.org/2429173004/ Remove unused primary_orbit arguments in QuicCryptoServerConfig In addition to being unused, pointers are being passed around in a way which all-but-ensures use of this buffer after the stack frame in which it lives has been torn down. dead and dangerous code removal only. No functional change intended, not flag-protected. Merge internal change: 136167866 https://codereview.chromium.org/2425073002/ Limit QUIC uncompressed header size per stream to 16K, by default. Protected by FLAGS_quic_limit_uncompressed_headers. Merge internal change: 136104265 https://codereview.chromium.org/2430513002/ Remove now useless QUIC method AdjustErrorForVersion() which has been a no-op for some time. Merge internal change: 136086635 https://codereview.chromium.org/2422343002/ Delete unused constants from quic_protocol.h. No behavior change. Merge internal change: 136075981 https://codereview.chromium.org/2425053002/ Implement a traffic policer in the simulator Merged internal change: 136068844 https://codereview.chromium.org/2425823002/ Test refactors to allow for delaying response trailers. Merge internal change: 136041302 https://codereview.chromium.org/2429653002/ Remove references to BalsaHeaders from a number of files and use SpdyHeaderBlock instead. Merge internal change: 135949023 https://codereview.chromium.org/2422233003/ Refactors for server-side asynchronous handshakes Merge internal change: 135837166 https://codereview.chromium.org/2427783002/ Allowing the SimpleQuicBackend to send an early response. Test-only change. Merge internal change: 135821831 https://codereview.chromium.org/2421173003/ Move allow_bidirectional_data_ from QuicSpdyClientStream to QuicSpdyStream, and use in (test-only) QuicSimpleServerStream. No behavior change. Merge internal change: 135812992 https://codereview.chromium.org/2424953002/ QUIC: only negotiate Token Binding when PrivacyMode is disabled Merge internal change: 135745087 https://codereview.chromium.org/2422243002/ Eliminate use of StringPiece(nullptr, n) with non zero n. This constructor is unsupported in C++17's 2-arg std::string_view. Merge internal change: 135733011 https://codereview.chromium.org/2421403002/ Deprecate FLAGS_quic_stream_sequencer_buffer_debug. Merge internal change: 135720045 https://codereview.chromium.org/2427663003/ Deprecate FLAGS_quic_close_connection_on_huge_frames. Merge internal change: 135697044 https://codereview.chromium.org/2429533003/ Deprecate FLAGS_quic_allow_server_address_change_for_mapped_ipv4. Merge internal change: 135694707 https://codereview.chromium.org/2424903002/ refactor only: Move around flag protection. Merge internal change: 135693757 https://codereview.chromium.org/2426603003/ Deprecate FLAGS_quic_packet_numbers_largest_received. Merge internal change: 135689518 https://codereview.chromium.org/2428623002/ rollback of internal changelist 134345701 *** Reason for rollback *** This has a bug that causes busy looping in chromium. *** Original change description *** bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_FLAGS_quic_bugfix_fhol_writev_fin_only. Fix bug in FHOL, where fin-only writev caused cpu-spinning in gfe. Also changes the behaviour of FHOL to limit additional buffering to one HTTP/2 Data frame. Merge internal change: 135689007 https://codereview.chromium.org/2424863002/ R=rch@chromium.org BUG= Committed: https://crrev.com/a72f535da35f62d302407256cf7bc4d7be4b9673 Cr-Commit-Position: refs/heads/master@{#426458}

Patch Set 1 #

Patch Set 2 : Adding the simulator fix (cr/136390076) to unbreak the policer test #

Patch Set 3 : fixing copy constructor #

Patch Set 4 : Removing an unnecessary flagsaver in the hopes it makes ios tests happier #

Patch Set 5 : Adding flagsavers where appropriate #

Patch Set 6 : Improving flagsaver logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1632 lines, -597 lines) Patch
M net/net.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 3 chunks +6 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 14 chunks +125 lines, -28 lines 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 5 chunks +33 lines, -67 lines 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_flags_list.h View 4 chunks +3 lines, -14 lines 0 comments Download
M net/quic/core/quic_framer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/core/quic_framer.cc View 3 chunks +11 lines, -31 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M net/quic/core/quic_header_list.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/core/quic_header_list.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M net/quic/core/quic_header_list_test.cc View 1 2 3 4 2 chunks +27 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 2 chunks +5 lines, -7 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 4 chunks +52 lines, -103 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 3 chunks +1 line, -69 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 1 chunk +14 lines, -18 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_protocol.h View 4 chunks +5 lines, -14 lines 0 comments Download
M net/quic/core/quic_protocol.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/core/quic_protocol_test.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 3 chunks +13 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.cc View 6 chunks +8 lines, -18 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/core/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/reliable_quic_stream.h View 1 chunk +1 line, -1 line 0 comments Download
A net/quic/test_tools/fake_proof_source.h View 1 chunk +84 lines, -0 lines 0 comments Download
A net/quic/test_tools/fake_proof_source.cc View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/simulator/simulator.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M net/quic/test_tools/simulator/simulator_test.cc View 3 chunks +120 lines, -0 lines 0 comments Download
A net/quic/test_tools/simulator/traffic_policer.h View 1 chunk +77 lines, -0 lines 0 comments Download
A net/quic/test_tools/simulator/traffic_policer.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 4 chunks +19 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 6 chunks +88 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +495 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 3 chunks +15 lines, -17 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 2 chunks +0 lines, -9 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M net/tools/quic/stateless_rejector.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 4 chunks +56 lines, -42 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +1 line, -25 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.h View 4 chunks +8 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (23 generated)
alyssar1
4 years, 2 months ago (2016-10-19 12:45:33 UTC) #1
Ryan Hamilton
LGTM mod my comments in https://codereview.chromium.org/2435773002/
4 years, 2 months ago (2016-10-19 18:38:59 UTC) #13
alyssar1
On 2016/10/19 18:38:59, Ryan Hamilton wrote: > LGTM mod my comments in https://codereview.chromium.org/2435773002/ As discussed ...
4 years, 2 months ago (2016-10-19 21:02:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430973004/100001
4 years, 2 months ago (2016-10-20 12:36:15 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-20 12:45:41 UTC) #27
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:17:42 UTC) #29
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/a72f535da35f62d302407256cf7bc4d7be4b9673
Cr-Commit-Position: refs/heads/master@{#426458}

Powered by Google App Engine
This is Rietveld 408576698