Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: net/quic/test_tools/quic_test_utils.cc

Issue 2430973004: Landing Recent QUIC changes until 10:38 AM, Oct 17, 2016 UTC-4 (Closed)
Patch Set: Improving flagsaver logging Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_session_peer.cc ('k') | net/quic/test_tools/simulator/simulator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_utils.cc
diff --git a/net/quic/test_tools/quic_test_utils.cc b/net/quic/test_tools/quic_test_utils.cc
index cbc0eb1cd25f950b274fb843b5bc5645162c6eb7..2a6ef34f268548e809c69f3a1f6d76a7dafe0bbf 100644
--- a/net/quic/test_tools/quic_test_utils.cc
+++ b/net/quic/test_tools/quic_test_utils.cc
@@ -98,7 +98,10 @@ QuicPacket* BuildUnsizedDataPacket(QuicFramer* framer,
}
QuicFlagSaver::QuicFlagSaver() {
-#define QUIC_FLAG(type, flag, value) CHECK_EQ(value, flag);
+#define QUIC_FLAG(type, flag, value) \
+ CHECK_EQ(value, flag) << "Flag set to an expected value. A prior test is " \
+ "likely setting a flag " \
+ << "without using a QuicFlagSaver";
#include "net/quic/core/quic_flags_list.h"
#undef QUIC_FLAG
}
« no previous file with comments | « net/quic/test_tools/quic_session_peer.cc ('k') | net/quic/test_tools/simulator/simulator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698