Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2430253003: Get rid of createVisibleSelection() to take EphemeralRange (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 2 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, dcheng, groby+blinkspell_chromium.org, kinuko+watch, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of createVisibleSelection() to take EphemeralRange This patch gets rid of |createVisibleSelection()| taking |EphemeralRange| by replacing with |SelectionInDOMTree| version to reduce number of overloads for improving code health. BUG=657237 TEST=n/a; no behavior changes Committed: https://crrev.com/237aeceb8741da6701d858cd5adeb5efc6810a35 Cr-Commit-Position: refs/heads/master@{#426430}

Patch Set 1 : 2016-10-19T18:04:09 #

Patch Set 2 : 2016-10-20T14:03:19 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 4 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/mac/WebSubstringUtil.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
yosin_UTC9
PTAL Not only core/editing but also - web/WebLocalFrameImpl.cpp - web/mac/WebSubstringUtil.mm
4 years, 2 months ago (2016-10-20 07:15:28 UTC) #11
Xiaocheng
lgtm
4 years, 2 months ago (2016-10-20 07:20:40 UTC) #12
tkent
lgtm
4 years, 2 months ago (2016-10-20 07:55:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430253003/20001
4 years, 2 months ago (2016-10-20 08:02:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 08:14:54 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:38 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/237aeceb8741da6701d858cd5adeb5efc6810a35
Cr-Commit-Position: refs/heads/master@{#426430}

Powered by Google App Engine
This is Rietveld 408576698