Get rid of createVisibleSelection() to take EphemeralRange

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 315 matching lines @@
         findFirstMisspelling(spellingSearchStart, spellingSearchEnd);
   }
 
   if (!misspelledWord.isEmpty()) {
     // We found a misspelling. Select the misspelling, update the spelling
     // panel, and store a marker so we draw the red squiggle later.
 
     const EphemeralRange misspellingRange = calculateCharacterSubrange(
         EphemeralRange(spellingSearchStart, spellingSearchEnd),
         misspellingOffset, misspelledWord.length());
-    frame().selection().setSelection(createVisibleSelection(misspellingRange));
+    frame().selection().setSelection(SelectionInDOMTree::Builder()
+                                         .setBaseAndExtent(misspellingRange)
+                                         .build());
     frame().selection().revealSelection();
     spellCheckerClient().updateSpellingUIWithMisspelledWord(misspelledWord);
     frame().document()->markers().addMarker(misspellingRange.startPosition(),
                                             misspellingRange.endPosition(),
                                             DocumentMarker::Spelling);
   }
 }
 
 void SpellChecker::showSpellingGuessPanel() {
   if (spellCheckerClient().spellingUIIsShowing()) {
@@ skipping 448 matching lines @@
   if (markers.size() < 1 ||
       markers[0]->startOffset() >= markers[0]->endOffset())
     return;
   EphemeralRange markerRange =
       EphemeralRange(Position(caretRange.startPosition().computeContainerNode(),
                               markers[0]->startOffset()),
                      Position(caretRange.endPosition().computeContainerNode(),
                               markers[0]->endOffset()));
   if (markerRange.isNull())
     return;
-  frame().selection().setSelection(createVisibleSelection(markerRange),
-                                   CharacterGranularity);
+  frame().selection().setSelection(
+      SelectionInDOMTree::Builder().setBaseAndExtent(markerRange).build());
 
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
   frame().editor().replaceSelectionWithText(text, false, false);
 }
 
 static bool shouldCheckOldSelection(const Position& oldSelectionStart) {
   if (!oldSelectionStart.isConnected())
@@ skipping 311 matching lines @@
         startOfNextParagraph(createVisiblePosition(paragraphEnd));
     paragraphStart = newParagraphStart.toParentAnchoredPosition();
     paragraphEnd = endOfParagraph(newParagraphStart).toParentAnchoredPosition();
     firstIteration = false;
     totalLengthProcessed += currentLength;
   }
   return std::make_pair(firstFoundItem, firstFoundOffset);
 }
 
 }  // namespace blink