Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2430253003: Get rid of createVisibleSelection() to take EphemeralRange (Closed)
Patch Set: 2016-10-20T14:03:19 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 // except for taking |SelectionInDOMTree| and |SelectionInFlatTree|. 215 // except for taking |SelectionInDOMTree| and |SelectionInFlatTree|.
216 CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&); 216 CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&);
217 CORE_EXPORT VisibleSelection createVisibleSelection(const Position&, 217 CORE_EXPORT VisibleSelection createVisibleSelection(const Position&,
218 TextAffinity, 218 TextAffinity,
219 bool isDirectional = false); 219 bool isDirectional = false);
220 CORE_EXPORT VisibleSelection 220 CORE_EXPORT VisibleSelection
221 createVisibleSelection(const Position& base, 221 createVisibleSelection(const Position& base,
222 const Position& extent, 222 const Position& extent,
223 TextAffinity = SelDefaultAffinity, 223 TextAffinity = SelDefaultAffinity,
224 bool isDirectional = false); 224 bool isDirectional = false);
225 CORE_EXPORT VisibleSelection
226 createVisibleSelection(const EphemeralRange&,
227 TextAffinity = SelDefaultAffinity,
228 bool isDirectional = false);
229 CORE_EXPORT VisibleSelection createVisibleSelection(const VisiblePosition&, 225 CORE_EXPORT VisibleSelection createVisibleSelection(const VisiblePosition&,
230 const VisiblePosition&, 226 const VisiblePosition&,
231 bool isDirectional = false); 227 bool isDirectional = false);
232 CORE_EXPORT VisibleSelection createVisibleSelection(const PositionWithAffinity&, 228 CORE_EXPORT VisibleSelection createVisibleSelection(const PositionWithAffinity&,
233 bool isDirectional = false); 229 bool isDirectional = false);
234 230
235 CORE_EXPORT VisibleSelectionInFlatTree 231 CORE_EXPORT VisibleSelectionInFlatTree
236 createVisibleSelection(const SelectionInFlatTree&); 232 createVisibleSelection(const SelectionInFlatTree&);
237 CORE_EXPORT VisibleSelectionInFlatTree 233 CORE_EXPORT VisibleSelectionInFlatTree
238 createVisibleSelection(const PositionInFlatTree& base, 234 createVisibleSelection(const PositionInFlatTree& base,
(...skipping 20 matching lines...) Expand all
259 255
260 #ifndef NDEBUG 256 #ifndef NDEBUG
261 // Outside the WebCore namespace for ease of invocation from gdb. 257 // Outside the WebCore namespace for ease of invocation from gdb.
262 void showTree(const blink::VisibleSelection&); 258 void showTree(const blink::VisibleSelection&);
263 void showTree(const blink::VisibleSelection*); 259 void showTree(const blink::VisibleSelection*);
264 void showTree(const blink::VisibleSelectionInFlatTree&); 260 void showTree(const blink::VisibleSelectionInFlatTree&);
265 void showTree(const blink::VisibleSelectionInFlatTree*); 261 void showTree(const blink::VisibleSelectionInFlatTree*);
266 #endif 262 #endif
267 263
268 #endif // VisibleSelection_h 264 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698