Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2430223006: Bindings: Rebaseline run-bindings-tests results (Closed)

Created:
4 years, 2 months ago by nhiroki
Modified:
4 years, 2 months ago
Reviewers:
haraken, peria, Yuki, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bindings: Rebaseline run-bindings-tests results This CL is generated by "run-bindings-tests --reset-results" BUG=n/a Committed: https://crrev.com/60f217501d3450730b082e80d31975d4f5e63758 Cr-Commit-Position: refs/heads/master@{#426413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -425 lines) Patch
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 53 chunks +54 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 262 chunks +263 lines, -268 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 22 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 8 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
nhiroki
Hi, can you review this? This is a follow-up CL for https://chromiumcodereview.appspot.com/2427223002. Thanks.
4 years, 2 months ago (2016-10-20 04:12:41 UTC) #5
bashi
Hmm, maybe presubmit hooks is not working these days? It should be caught by presubmit ...
4 years, 2 months ago (2016-10-20 04:17:39 UTC) #7
haraken
> Hmm, maybe presubmit hooks is not working these days? It should be caught by ...
4 years, 2 months ago (2016-10-20 04:18:23 UTC) #8
peria
Thank you for catching up this! Hmm, this change should be caught in my last ...
4 years, 2 months ago (2016-10-20 04:25:04 UTC) #9
nhiroki
Thank you! The presubmit checker (current ToT) seems to be working fine on my Linux ...
4 years, 2 months ago (2016-10-20 04:32:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430223006/1
4 years, 2 months ago (2016-10-20 04:33:47 UTC) #15
nhiroki
On 2016/10/20 04:25:04, peria wrote: > Thank you for catching up this! > Hmm, this ...
4 years, 2 months ago (2016-10-20 04:34:37 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 05:14:16 UTC) #18
Yuki
lgtm
4 years, 2 months ago (2016-10-20 05:28:03 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:01 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60f217501d3450730b082e80d31975d4f5e63758
Cr-Commit-Position: refs/heads/master@{#426413}

Powered by Google App Engine
This is Rietveld 408576698