Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2427223002: [Bindings] Expose callback functions for methods (Closed)

Created:
4 years, 2 months ago by peria
Modified:
4 years, 2 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose callback functions for methods in bindings generated code. Those functions will be referred from other files, so they should not be encapsulated. BUG=617892 Committed: https://crrev.com/8213672b2d3403720975019fce07b6379686b1d1 Cr-Commit-Position: refs/heads/master@{#426185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
peria
4 years, 2 months ago (2016-10-19 02:27:02 UTC) #3
peria
PTL
4 years, 2 months ago (2016-10-19 02:27:10 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-19 02:53:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427223002/1
4 years, 2 months ago (2016-10-19 03:04:26 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-19 05:11:15 UTC) #9
Yuki
lgtm
4 years, 2 months ago (2016-10-19 05:35:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427223002/1
4 years, 2 months ago (2016-10-19 05:44:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/298508) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 2 months ago (2016-10-19 09:54:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427223002/1
4 years, 2 months ago (2016-10-19 10:36:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/298945)
4 years, 2 months ago (2016-10-19 13:16:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427223002/1
4 years, 2 months ago (2016-10-19 14:01:33 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 14:52:35 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:14 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8213672b2d3403720975019fce07b6379686b1d1
Cr-Commit-Position: refs/heads/master@{#426185}

Powered by Google App Engine
This is Rietveld 408576698