|
|
DescriptionExpose callback functions for methods in bindings generated code.
Those functions will be referred from other files, so they
should not be encapsulated.
BUG=617892
Committed: https://crrev.com/8213672b2d3403720975019fce07b6379686b1d1
Cr-Commit-Position: refs/heads/master@{#426185}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
Description was changed from ========== Expose callback functions in methods.cpp.tmpl BUG=617892 ========== to ========== Expose callback functions for methods in bindings generated code. Those functions will be referred from other files, so they should not be encapsulated. BUG=617892 ==========
peria@chromium.org changed reviewers: + bashi@chromium.org, yukishiino@chromium.org
PTL
LGTM
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
lgtm
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Expose callback functions for methods in bindings generated code. Those functions will be referred from other files, so they should not be encapsulated. BUG=617892 ========== to ========== Expose callback functions for methods in bindings generated code. Those functions will be referred from other files, so they should not be encapsulated. BUG=617892 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Expose callback functions for methods in bindings generated code. Those functions will be referred from other files, so they should not be encapsulated. BUG=617892 ========== to ========== Expose callback functions for methods in bindings generated code. Those functions will be referred from other files, so they should not be encapsulated. BUG=617892 Committed: https://crrev.com/8213672b2d3403720975019fce07b6379686b1d1 Cr-Commit-Position: refs/heads/master@{#426185} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8213672b2d3403720975019fce07b6379686b1d1 Cr-Commit-Position: refs/heads/master@{#426185} |