[wasm] Improve naming consistency for WASM instances.

[wasm] Improve naming consistency for WASM instances.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=

Committed: https://crrev.com/acf99a893c4a3d6d4372b6f192220c4fe3888e03
Cr-Commit-Position: refs/heads/master@{#40426}

[titzer, 2016-10-19 08:57:10]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 08:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-10-19 09:05:37]

lgtm with nits

https://codereview.chromium.org/2428343005/diff/1/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/2428343005/diff/1/src/messages.cc#newcode626
src/messages.cc:626: wasm_instance_ = handle(array->WasmObject(frame_ix),
isolate);
should array->WasmObject also be array->WasmInstance?

https://codereview.chromium.org/2428343005/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2428343005/diff/1/src/wasm/wasm-js.cc#newcode797
src/wasm/wasm-js.cc:797: Handle<JSObject> webassembly =
factory->NewJSObject(cons, TENURED);
I think we rarely use "webassembly" in our code base. Would it be better to call
the variable "wasm"?

[titzer, 2016-10-19 09:13:50]

https://codereview.chromium.org/2428343005/diff/1/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/2428343005/diff/1/src/messages.cc#newcode626
src/messages.cc:626: wasm_instance_ = handle(array->WasmObject(frame_ix),
isolate);
On 2016/10/19 09:05:37, ahaas wrote:
> should array->WasmObject also be array->WasmInstance?

Good catch. Done.

https://codereview.chromium.org/2428343005/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2428343005/diff/1/src/wasm/wasm-js.cc#newcode797
src/wasm/wasm-js.cc:797: Handle<JSObject> webassembly =
factory->NewJSObject(cons, TENURED);
On 2016/10/19 09:05:37, ahaas wrote:
> I think we rarely use "webassembly" in our code base. Would it be better to
call
> the variable "wasm"?

You're right. I did this on purpose because this is the "WebAssembly" JavaScript
object.

[titzer, 2016-10-19 09:21:43]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-10-19 09:21:43]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2428343005/#ps20001
(title: "Also rename FrameArray::WasmObject")

[commit-bot: I haz the power, 2016-10-19 09:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-19 09:43:29]

lgtm, but lots of merge conflicts incoming ;)

[commit-bot: I haz the power, 2016-10-19 10:30:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:05:59]

Description was changed from

==========
[wasm] Improve naming consistency for WASM instances.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Improve naming consistency for WASM instances.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=

Committed: https://crrev.com/acf99a893c4a3d6d4372b6f192220c4fe3888e03
Cr-Commit-Position: refs/heads/master@{#40426}
==========

[commit-bot: I haz the power, 2016-11-17 22:06:01]

Patchset 2 (id:??) landed as
https://crrev.com/acf99a893c4a3d6d4372b6f192220c4fe3888e03
Cr-Commit-Position: refs/heads/master@{#40426}