Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: src/wasm/wasm-module.h

Issue 2428343005: [wasm] Improve naming consistency for WASM instances. (Closed)
Patch Set: Also rename FrameArray::WasmObject Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-js.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 3ee5e597894b59a6f46d1f7bda5608cc459f8c32..1adad17361c403688bc88c27ef33d9644b8fca86 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -495,27 +495,27 @@ Handle<JSFunction> WrapExportCodeAsJSFunction(Isolate* isolate,
Handle<Code> export_code,
Handle<String> name, int arity,
MaybeHandle<ByteArray> signature,
- Handle<JSObject> module_instance);
+ Handle<JSObject> instance);
// Check whether the given object is a wasm object.
// This checks the number and type of internal fields, so it's not 100 percent
// secure. If it turns out that we need more complete checks, we could add a
// special marker as internal field, which will definitely never occur anywhere
// else.
-bool IsWasmObject(Object* object);
+bool IsWasmInstance(Object* object);
// Return the compiled module object for this wasm object.
-WasmCompiledModule* GetCompiledModule(JSObject* wasm);
+WasmCompiledModule* GetCompiledModule(JSObject* instance);
// Check whether the wasm module was generated from asm.js code.
-bool WasmIsAsmJs(Object* wasm, Isolate* isolate);
+bool WasmIsAsmJs(Object* instance, Isolate* isolate);
// Get the script for the asm.js origin of the wasm module.
-Handle<Script> GetAsmWasmScript(Handle<JSObject> wasm);
+Handle<Script> GetAsmWasmScript(Handle<JSObject> instance);
// Get the asm.js source position for the given byte offset in the given
// function.
-int GetAsmWasmSourcePosition(Handle<JSObject> wasm, int func_index,
+int GetAsmWasmSourcePosition(Handle<JSObject> instance, int func_index,
int byte_offset);
// Constructs a single function table as a FixedArray of double size,
@@ -543,7 +543,7 @@ V8_EXPORT_PRIVATE bool ValidateModuleBytes(Isolate* isolate, const byte* start,
ModuleOrigin origin);
// Get the number of imported functions for a WASM instance.
-int GetNumImportedFunctions(Handle<JSObject> wasm_object);
+int GetNumImportedFunctions(Handle<JSObject> instance);
// Assumed to be called with a code object associated to a wasm module instance.
// Intended to be called from runtime functions.
« no previous file with comments | « src/wasm/wasm-js.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698