Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: src/objects.h

Issue 2428343005: [wasm] Improve naming consistency for WASM instances. (Closed)
Patch Set: Also rename FrameArray::WasmObject Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 6e1959243b14a073d0f2346961295f405a20c22c..a125f5b91d11a2c8febc7e0b5b3deb194059d5f2 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -3109,7 +3109,7 @@ class V8_EXPORT_PRIVATE RegExpMatchInfo : NON_EXPORTED_BASE(public FixedArray) {
};
#define FRAME_ARRAY_FIELD_LIST(V) \
- V(WasmObject, Object) \
+ V(WasmInstance, Object) \
V(WasmFunctionIndex, Smi) \
V(Receiver, Object) \
V(Function, JSFunction) \
@@ -3144,7 +3144,7 @@ class FrameArray : public FixedArray {
Handle<AbstractCode> code, int offset,
int flags);
static Handle<FrameArray> AppendWasmFrame(Handle<FrameArray> in,
- Handle<Object> wasm_object,
+ Handle<Object> wasm_instance,
int wasm_function_index,
Handle<AbstractCode> code,
int offset, int flags);
@@ -3159,7 +3159,7 @@ class FrameArray : public FixedArray {
//
// with internal offsets as below:
- static const int kWasmObjectOffset = 0;
+ static const int kWasmInstanceOffset = 0;
static const int kWasmFunctionIndexOffset = 1;
static const int kReceiverOffset = 0;
@@ -7092,9 +7092,9 @@ class Script: public Struct {
// [source_mapping_url]: sourceMappingURL magic comment
DECL_ACCESSORS(source_mapping_url, Object)
- // [wasm_object]: the wasm object this script belongs to.
+ // [wasm_instance]: the wasm instance this script belongs to.
// This must only be called if the type of this script is TYPE_WASM.
- DECL_ACCESSORS(wasm_object, JSObject)
+ DECL_ACCESSORS(wasm_instance, JSObject)
// [wasm_function_index]: the wasm function index this script belongs to.
// This must only be called if the type of this script is TYPE_WASM.
« no previous file with comments | « src/messages.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698