Fix wrong cast in ExtensionsGuestViewContainer.

Fix wrong cast in ExtensionsGuestViewContainer.

This change moves DidResizeElement from ExtensionsGuestViewContainer to GuestViewContainer, so we don't need the cast to ExtensionsGuestViewContainer.

BUG=625475
Committed: https://crrev.com/a539cacdcc17694e23c30fc0eb10ffe150129a3a
Cr-Commit-Position: refs/heads/master@{#426637}

[lfg, 2016-10-18 17:09:41]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 17:10:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:52:27]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-10-18 18:59:21]

lfg@chromium.org changed reviewers:
+ meacer@chromium.org

[lfg, 2016-10-18 18:59:21]

Hello, since you triaged this bug, do you mind taking a look?

[lfg, 2016-10-18 19:00:06]

Description was changed from

==========
Fix wrong cast in ExtensionsGuestViewContainer.

BUG=625475
==========

to

==========
Fix wrong cast in ExtensionsGuestViewContainer.

This change moves DidResizeElement from ExtensionsGuestViewContainer to
GuestViewContainer, so we don't need the cast to ExtensionsGuestViewContainer.

BUG=625475
==========

[meacer, 2016-10-18 19:41:54]

Lgtm

https://codereview.chromium.org/2427893003/diff/1/extensions/renderer/guest_v...
File extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
(right):

https://codereview.chromium.org/2427893003/diff/1/extensions/renderer/guest_v...
extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc:253:
guest_view::GuestViewContainer::FromID(element_instance_id));
Can you also remove this cast? It's not really necessary.

[lfg, 2016-10-19 18:13:32]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 18:13:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2016-10-19 19:18:20]

The CQ bit was unchecked by lfg@chromium.org

[lfg, 2016-10-19 19:18:20]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-10-19 19:18:21]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2427893003/#ps20001
(title: "remove cast")

[lfg, 2016-10-19 19:18:40]

https://codereview.chromium.org/2427893003/diff/1/extensions/renderer/guest_v...
File extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
(right):

https://codereview.chromium.org/2427893003/diff/1/extensions/renderer/guest_v...
extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc:253:
guest_view::GuestViewContainer::FromID(element_instance_id));
On 2016/10/18 19:41:53, Mustafa Emre Acer wrote:
> Can you also remove this cast? It's not really necessary.

Done.

[commit-bot: I haz the power, 2016-10-19 19:19:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 19:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 19:46:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lfg, 2016-10-19 19:52:18]

lfg@chromium.org changed reviewers:
+ danakj@chromium.org

[lfg, 2016-10-19 19:52:18]

+danakj, can you take a look at the DEPS file?

[danakj, 2016-10-20 20:37:04]

https://chromiumcodereview.appspot.com/2427893003/diff/20001/components/guest...
File components/guest_view/renderer/DEPS (right):

https://chromiumcodereview.appspot.com/2427893003/diff/20001/components/guest...
components/guest_view/renderer/DEPS:6: "+ui/gfx",
I think you want ui/gfx/geometry?

[lfg, 2016-10-20 21:13:37]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 21:14:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2016-10-20 22:18:56]

https://codereview.chromium.org/2427893003/diff/20001/components/guest_view/r...
File components/guest_view/renderer/DEPS (right):

https://codereview.chromium.org/2427893003/diff/20001/components/guest_view/r...
components/guest_view/renderer/DEPS:6: "+ui/gfx",
On 2016/10/20 20:37:04, danakj wrote:
> I think you want ui/gfx/geometry?

Done.

[danakj, 2016-10-20 22:21:14]

https://codereview.chromium.org/2427893003/diff/40001/components/guest_view/r...
File components/guest_view/renderer/DEPS (right):

https://codereview.chromium.org/2427893003/diff/40001/components/guest_view/r...
components/guest_view/renderer/DEPS:6: "+ui/gfx/geometry",
LGTM

[commit-bot: I haz the power, 2016-10-20 22:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:46:04]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-10-20 22:51:37]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-10-20 22:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2427893003/#ps40001
(title: "update deps")

[commit-bot: I haz the power, 2016-10-20 22:52:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 23:09:24]

Description was changed from

==========
Fix wrong cast in ExtensionsGuestViewContainer.

This change moves DidResizeElement from ExtensionsGuestViewContainer to
GuestViewContainer, so we don't need the cast to ExtensionsGuestViewContainer.

BUG=625475
==========

to

==========
Fix wrong cast in ExtensionsGuestViewContainer.

This change moves DidResizeElement from ExtensionsGuestViewContainer to
GuestViewContainer, so we don't need the cast to ExtensionsGuestViewContainer.

BUG=625475
==========

[commit-bot: I haz the power, 2016-10-20 23:09:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:24:10]

Description was changed from

==========
Fix wrong cast in ExtensionsGuestViewContainer.

This change moves DidResizeElement from ExtensionsGuestViewContainer to
GuestViewContainer, so we don't need the cast to ExtensionsGuestViewContainer.

BUG=625475
==========

to

==========
Fix wrong cast in ExtensionsGuestViewContainer.

This change moves DidResizeElement from ExtensionsGuestViewContainer to
GuestViewContainer, so we don't need the cast to ExtensionsGuestViewContainer.

BUG=625475

Committed: https://crrev.com/a539cacdcc17694e23c30fc0eb10ffe150129a3a
Cr-Commit-Position: refs/heads/master@{#426637}
==========

[commit-bot: I haz the power, 2016-10-21 13:24:15]

Patchset 3 (id:??) landed as
https://crrev.com/a539cacdcc17694e23c30fc0eb10ffe150129a3a
Cr-Commit-Position: refs/heads/master@{#426637}