Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Side by Side Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 2427893003: Fix wrong cast in ExtensionsGuestViewContainer. (Closed)
Patch Set: update deps Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/guest_view/extensions_guest_view_container.h" 5 #include "extensions/renderer/guest_view/extensions_guest_view_container.h"
6 6
7 #include "base/location.h"
8 #include "base/single_thread_task_runner.h"
9 #include "base/threading/thread_task_runner_handle.h"
10 #include "content/public/renderer/render_frame.h"
11 #include "ui/gfx/geometry/size.h"
12
13 namespace extensions { 7 namespace extensions {
14 8
15 ExtensionsGuestViewContainer::ExtensionsGuestViewContainer( 9 ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(
16 content::RenderFrame* render_frame) 10 content::RenderFrame* render_frame)
17 : GuestViewContainer(render_frame), 11 : GuestViewContainer(render_frame) {
18 element_resize_isolate_(nullptr),
19 weak_ptr_factory_(this) {
20 } 12 }
21 13
22 ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() { 14 ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
23 } 15 }
24 16
25 void ExtensionsGuestViewContainer::OnDestroy(bool embedder_frame_destroyed) { 17 void ExtensionsGuestViewContainer::OnDestroy(bool embedder_frame_destroyed) {
26 } 18 }
27 19
28 void ExtensionsGuestViewContainer::RegisterElementResizeCallback(
29 v8::Local<v8::Function> callback,
30 v8::Isolate* isolate) {
31 element_resize_callback_.Reset(isolate, callback);
32 element_resize_isolate_ = isolate;
33 }
34
35 void ExtensionsGuestViewContainer::DidResizeElement(const gfx::Size& new_size) {
36 // Call the element resize callback, if one is registered.
37 if (element_resize_callback_.IsEmpty())
38 return;
39
40 base::ThreadTaskRunnerHandle::Get()->PostTask(
41 FROM_HERE,
42 base::Bind(&ExtensionsGuestViewContainer::CallElementResizeCallback,
43 weak_ptr_factory_.GetWeakPtr(), new_size));
44 }
45
46 void ExtensionsGuestViewContainer::CallElementResizeCallback(
47 const gfx::Size& new_size) {
48 v8::HandleScope handle_scope(element_resize_isolate_);
49 v8::Local<v8::Function> callback = v8::Local<v8::Function>::New(
50 element_resize_isolate_, element_resize_callback_);
51 v8::Local<v8::Context> context = callback->CreationContext();
52 if (context.IsEmpty())
53 return;
54
55 const int argc = 2;
56 v8::Local<v8::Value> argv[argc] = {
57 v8::Integer::New(element_resize_isolate_, new_size.width()),
58 v8::Integer::New(element_resize_isolate_, new_size.height())};
59
60 v8::Context::Scope context_scope(context);
61 v8::MicrotasksScope microtasks(
62 element_resize_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);
63
64 callback->Call(context->Global(), argc, argv);
65 }
66
67 } // namespace extensions 20 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698