Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: components/guest_view/renderer/guest_view_container.h

Issue 2427893003: Fix wrong cast in ExtensionsGuestViewContainer. (Closed)
Patch Set: update deps Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/renderer/guest_view_container.h
diff --git a/components/guest_view/renderer/guest_view_container.h b/components/guest_view/renderer/guest_view_container.h
index 0218e5a75caac8978713271514c6ea849773cbdc..53fe3ef2fe98e09e6c078a454c73128fba578367 100644
--- a/components/guest_view/renderer/guest_view_container.h
+++ b/components/guest_view/renderer/guest_view_container.h
@@ -41,6 +41,8 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
void RegisterDestructionCallback(v8::Local<v8::Function> callback,
v8::Isolate* isolate);
+ void RegisterElementResizeCallback(v8::Local<v8::Function> callback,
+ v8::Isolate* isolate);
// Called when the embedding RenderFrame is destroyed.
virtual void OnRenderFrameDestroyed() {}
@@ -59,6 +61,7 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
// BrowserPluginGuestDelegate public implementation.
void SetElementInstanceID(int element_instance_id) final;
+ void DidResizeElement(const gfx::Size& new_size) override;
protected:
~GuestViewContainer() override;
@@ -77,6 +80,7 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
void PerformPendingRequest();
void HandlePendingResponseCallback(const IPC::Message& message);
void RunDestructionCallback(bool embedder_frame_destroyed);
+ void CallElementResizeCallback(const gfx::Size& new_size);
// BrowserPluginDelegate implementation.
void Ready() final;
@@ -95,6 +99,9 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
v8::Global<v8::Function> destruction_callback_;
v8::Isolate* destruction_isolate_;
+ v8::Global<v8::Function> element_resize_callback_;
+ v8::Isolate* element_resize_isolate_;
+
base::WeakPtrFactory<GuestViewContainer> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(GuestViewContainer);

Powered by Google App Engine
This is Rietveld 408576698