Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2424983004: Introduce enum InputType::ValueMode. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce enum InputType::ValueMode. This represents four value modes defined in [1], and it replaces InputType::storesValueSeparateFromAttribute(). This CL makes it easier to compare the code and the specification. This CL has no behavior changes. [1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-value Committed: https://crrev.com/4c4977aa052dad072bcf9539f2b4507b084e8f27 Cr-Commit-Position: refs/heads/master@{#426117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseButtonInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/HiddenInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/HiddenInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 2 months ago (2016-10-18 10:15:33 UTC) #4
keishi
LGTM
4 years, 2 months ago (2016-10-19 01:43:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424983004/1
4 years, 2 months ago (2016-10-19 01:46:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 01:58:13 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c4977aa052dad072bcf9539f2b4507b084e8f27
Cr-Commit-Position: refs/heads/master@{#426117}

Powered by Google App Engine
This is Rietveld 408576698