third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp - Issue 2424983004: Introduce enum InputType::ValueMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

Issue 2424983004: Introduce enum InputType::ValueMode. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h ('k') | third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

index 5ebffeb78f108a5348c3af41f447e16708ce7069..ffea71eec0b2c0091705e8823880c14bca2c904e 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp

@@ -102,8 +102,8 @@ String BaseCheckableInputType::fallbackValue() const {

return "on";

}

-bool BaseCheckableInputType::storesValueSeparateFromAttribute() {

- return false;

+InputType::ValueMode BaseCheckableInputType::valueMode() const {

+ return ValueMode::kDefaultOn;

}

void BaseCheckableInputType::setValue(const String& sanitizedValue,