Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android

Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android

Observer lists now support range-based for loops.

BUG=655021
Committed: https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c
Cr-Commit-Position: refs/heads/master@{#426158}

[Eric Willigers, 2016-10-18 23:24:12]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2016-10-18 23:24:38]

ericwilligers@chromium.org changed reviewers:
+ bauerb@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:25:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bernhard Bauer, 2016-10-19 10:34:09]

lgtm

https://codereview.chromium.org/2423883005/diff/1/chrome/browser/android/book...
File chrome/browser/android/bookmarks/partner_bookmarks_shim.cc (right):

https://codereview.chromium.org/2423883005/diff/1/chrome/browser/android/book...
chrome/browser/android/bookmarks/partner_bookmarks_shim.cc:126: for (auto&
observer : observers_)
Nit: I'm not sure if there is official guidance, but I would prefer to use the
actual type instead of auto.

[msramek, 2016-10-19 10:50:01]

msramek@chromium.org changed reviewers:
+ msramek@chromium.org

[msramek, 2016-10-19 10:50:02]

https://codereview.chromium.org/2423883005/diff/1/chrome/browser/android/book...
File chrome/browser/android/bookmarks/partner_bookmarks_shim.cc (right):

https://codereview.chromium.org/2423883005/diff/1/chrome/browser/android/book...
chrome/browser/android/bookmarks/partner_bookmarks_shim.cc:126: for (auto&
observer : observers_)
On 2016/10/19 10:34:09, Bernhard Bauer wrote:
> Nit: I'm not sure if there is official guidance, but I would prefer to use the
> actual type instead of auto. 

Since this CL was caught by my watchlist, I'll shamelessly jump in to add +1.

Here's the style guide: https://google.github.io/styleguide/cppguide.html#auto

Auto is preferred for iterations over std::map (because people forget the const
modifier for keys) and for container ::iterators which have long types, but not
necessarily for iterations in general.

It's not preferred if the type is "declared far away", which I think is
applicable. The |observers_| declaration is not nearby, so I don't know what
type |observer| is (even though I can make an educated guess).

[Eric Willigers, 2016-10-19 11:27:44]

https://codereview.chromium.org/2423883005/diff/1/chrome/browser/android/book...
File chrome/browser/android/bookmarks/partner_bookmarks_shim.cc (right):

https://codereview.chromium.org/2423883005/diff/1/chrome/browser/android/book...
chrome/browser/android/bookmarks/partner_bookmarks_shim.cc:126: for (auto&
observer : observers_)
On 2016/10/19 10:34:09, Bernhard Bauer wrote:
> Nit: I'm not sure if there is official guidance, but I would prefer to use the
> actual type instead of auto. 

Done.

[Eric Willigers, 2016-10-19 11:27:57]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-10-19 11:27:57]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2423883005/#ps20001
(title: "explicit types")

[commit-bot: I haz the power, 2016-10-19 11:28:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-10-19 11:42:51]

Thanks! Still LGTM.

https://codereview.chromium.org/2423883005/diff/20001/chrome/browser/android/...
File chrome/browser/android/bookmarks/partner_bookmarks_shim.cc (right):

https://codereview.chromium.org/2423883005/diff/20001/chrome/browser/android/...
chrome/browser/android/bookmarks/partner_bookmarks_shim.cc:126: for
(PartnerBookmarksShim::Observer& observer : observers_)
I think you could just use Observer (you're inside PartnerBookmarksShim anyway).

[commit-bot: I haz the power, 2016-10-19 12:30:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:07:19]

Description was changed from

==========
Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android

Observer lists now support range-based for loops.

BUG=655021
==========

to

==========
Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android

Observer lists now support range-based for loops.

BUG=655021

Committed: https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c
Cr-Commit-Position: refs/heads/master@{#426158}
==========

[commit-bot: I haz the power, 2016-10-21 13:07:20]

Patchset 2 (id:??) landed as
https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c
Cr-Commit-Position: refs/heads/master@{#426158}