Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/android/data_usage/data_use_tab_model.cc

Issue 2423883005: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/data_usage/data_use_tab_model.h" 5 #include "chrome/browser/android/data_usage/data_use_tab_model.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 bool DataUseTabModel::IsCustomTabPackageMatch(SessionID::id_type tab_id) const { 320 bool DataUseTabModel::IsCustomTabPackageMatch(SessionID::id_type tab_id) const {
321 DCHECK(thread_checker_.CalledOnValidThread()); 321 DCHECK(thread_checker_.CalledOnValidThread());
322 TabEntryMap::const_iterator tab_entry_iterator = active_tabs_.find(tab_id); 322 TabEntryMap::const_iterator tab_entry_iterator = active_tabs_.find(tab_id);
323 return (tab_entry_iterator != active_tabs_.end()) && 323 return (tab_entry_iterator != active_tabs_.end()) &&
324 tab_entry_iterator->second.is_custom_tab_package_match(); 324 tab_entry_iterator->second.is_custom_tab_package_match();
325 } 325 }
326 326
327 void DataUseTabModel::NotifyObserversOfTrackingStarting( 327 void DataUseTabModel::NotifyObserversOfTrackingStarting(
328 SessionID::id_type tab_id) { 328 SessionID::id_type tab_id) {
329 DCHECK(thread_checker_.CalledOnValidThread()); 329 DCHECK(thread_checker_.CalledOnValidThread());
330 FOR_EACH_OBSERVER(TabDataUseObserver, observers_, 330 for (TabDataUseObserver& observer : observers_)
331 NotifyTrackingStarting(tab_id)); 331 observer.NotifyTrackingStarting(tab_id);
332 } 332 }
333 333
334 void DataUseTabModel::NotifyObserversOfTrackingEnding( 334 void DataUseTabModel::NotifyObserversOfTrackingEnding(
335 SessionID::id_type tab_id) { 335 SessionID::id_type tab_id) {
336 DCHECK(thread_checker_.CalledOnValidThread()); 336 DCHECK(thread_checker_.CalledOnValidThread());
337 FOR_EACH_OBSERVER(TabDataUseObserver, observers_, 337 for (TabDataUseObserver& observer : observers_)
338 NotifyTrackingEnding(tab_id)); 338 observer.NotifyTrackingEnding(tab_id);
339 } 339 }
340 340
341 void DataUseTabModel::NotifyObserversOfDataUseTabModelReady() { 341 void DataUseTabModel::NotifyObserversOfDataUseTabModelReady() {
342 DCHECK(thread_checker_.CalledOnValidThread()); 342 DCHECK(thread_checker_.CalledOnValidThread());
343 FOR_EACH_OBSERVER(TabDataUseObserver, observers_, OnDataUseTabModelReady()); 343 for (TabDataUseObserver& observer : observers_)
344 observer.OnDataUseTabModelReady();
344 } 345 }
345 346
346 void DataUseTabModel::GetCurrentAndNewLabelForNavigationEvent( 347 void DataUseTabModel::GetCurrentAndNewLabelForNavigationEvent(
347 SessionID::id_type tab_id, 348 SessionID::id_type tab_id,
348 TransitionType transition, 349 TransitionType transition,
349 const GURL& url, 350 const GURL& url,
350 const std::string& package, 351 const std::string& package,
351 const content::NavigationEntry* navigation_entry, 352 const content::NavigationEntry* navigation_entry,
352 std::string* current_label, 353 std::string* current_label,
353 std::string* new_label, 354 std::string* new_label,
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 NowTicks() - 515 NowTicks() -
515 oldest_tab_entry_iterator->second.GetLatestStartOrEndTime(), 516 oldest_tab_entry_iterator->second.GetLatestStartOrEndTime(),
516 base::TimeDelta::FromMinutes(1), base::TimeDelta::FromHours(1), 50); 517 base::TimeDelta::FromMinutes(1), base::TimeDelta::FromHours(1), 50);
517 active_tabs_.erase(oldest_tab_entry_iterator); 518 active_tabs_.erase(oldest_tab_entry_iterator);
518 } 519 }
519 } 520 }
520 521
521 } // namespace android 522 } // namespace android
522 523
523 } // namespace chrome 524 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698