Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3072)

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model.cc

Issue 2423883005: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_tab_model.cc
diff --git a/chrome/browser/android/data_usage/data_use_tab_model.cc b/chrome/browser/android/data_usage/data_use_tab_model.cc
index 3a67b5d94c8df78dc2b459e0d510c93784e98e3b..a1929ac4879991b69681907fc92f0bb4f675148b 100644
--- a/chrome/browser/android/data_usage/data_use_tab_model.cc
+++ b/chrome/browser/android/data_usage/data_use_tab_model.cc
@@ -327,20 +327,21 @@ bool DataUseTabModel::IsCustomTabPackageMatch(SessionID::id_type tab_id) const {
void DataUseTabModel::NotifyObserversOfTrackingStarting(
SessionID::id_type tab_id) {
DCHECK(thread_checker_.CalledOnValidThread());
- FOR_EACH_OBSERVER(TabDataUseObserver, observers_,
- NotifyTrackingStarting(tab_id));
+ for (TabDataUseObserver& observer : observers_)
+ observer.NotifyTrackingStarting(tab_id);
}
void DataUseTabModel::NotifyObserversOfTrackingEnding(
SessionID::id_type tab_id) {
DCHECK(thread_checker_.CalledOnValidThread());
- FOR_EACH_OBSERVER(TabDataUseObserver, observers_,
- NotifyTrackingEnding(tab_id));
+ for (TabDataUseObserver& observer : observers_)
+ observer.NotifyTrackingEnding(tab_id);
}
void DataUseTabModel::NotifyObserversOfDataUseTabModelReady() {
DCHECK(thread_checker_.CalledOnValidThread());
- FOR_EACH_OBSERVER(TabDataUseObserver, observers_, OnDataUseTabModelReady());
+ for (TabDataUseObserver& observer : observers_)
+ observer.OnDataUseTabModelReady();
}
void DataUseTabModel::GetCurrentAndNewLabelForNavigationEvent(

Powered by Google App Engine
This is Rietveld 408576698