Reload ChromeVox panel when reloading ChromeVox into a new profile.

Reload ChromeVox panel when reloading ChromeVox into a new profile.

The ChromeVox panel needs to be reloaded when we load ChromeVox into a
new profile.

BUG=645142, 646636
TESTED=enable ChromeVox on login screen, then sign in and test that panel still works, then switch to lock screen and back to login screen

Committed: https://crrev.com/63199b19ad4d7f82913d7fab619cb78237ed7440
Cr-Commit-Position: refs/heads/master@{#426202}

[dmazzoni, 2016-10-17 19:34:44]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-10-17 19:34:59]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:35:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 20:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 20:55:11]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2016-10-19 15:01:47]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-19 15:01:57]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-10-19 15:02:35]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-19 15:02:35]

lgtm

[commit-bot: I haz the power, 2016-10-19 15:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 15:45:03]

Committed patchset #1 (id:1)

[huangs, 2016-10-19 17:38:14]

huangs@chromium.org changed reviewers:
+ huangs@chromium.org

[huangs, 2016-10-19 17:38:15]

A bunch of browser_test failure have cropped up, and they look
accessibility-related with message: 

*** Begin accessibility audit results ***
An accessibility audit found
Errors:
Error: AX_ARIA_08 (Elements with ARIA roles must ensure required owned elements
are present) failed on the following elements (1 - 2 of 2):
#default-search-engine-list
#other-search-engine-list

Could this CL have something to do with this (e.g., reveal existing bug)?

[David Tseng, 2016-10-19 17:48:17]

Unlikely as this cl doesn't touch any assets related to settings/the
referenced UI.

On Wed, Oct 19, 2016 at 10:38 AM, <huangs@chromium.org> wrote:

> A bunch of browser_test failure have cropped up, and they look
> accessibility-related with message:
>
> *** Begin accessibility audit results ***
> An accessibility audit found
> Errors:
> Error: AX_ARIA_08 (Elements with ARIA roles must ensure required owned
> elements
> are present) failed on the following elements (1 - 2 of 2):
> #default-search-engine-list
> #other-search-engine-list
>
> Could this CL have something to do with this (e.g., reveal existing bug)?
>
> https://chromiumcodereview.appspot.com/2422983004/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-10-19 17:58:28]

On 2016/10/19 17:38:15, huangs wrote:
> A bunch of browser_test failure have cropped up, and they look
> accessibility-related with message: 
> 
> *** Begin accessibility audit results ***
> An accessibility audit found
> Errors:
> Error: AX_ARIA_08 (Elements with ARIA roles must ensure required owned
elements
> are present) failed on the following elements (1 - 2 of 2):
> #default-search-engine-list
> #other-search-engine-list
> 
> Could this CL have something to do with this (e.g., reveal existing bug)?

Agreed, unlikely.

Look for a change that modified chrome/browser/resources

[huangs, 2016-10-19 18:16:29]

For changes over the last day, that narrows things down to 

https://chromiumcodereview.appspot.com/2399673005 (dtseng@)
https://chromiumcodereview.appspot.com/2402913002 (tsergeant@)
https://chromiumcodereview.appspot.com/2387533003 (dmazzoni@)

[huangs, 2016-10-19 18:24:15]

Perhaps that we're breaking

https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rule...

beacause #default-search-engine-list in

    <list id="default-search-engine-list"
        class="search-engine-list settings-list"></list>

https://cs.chromium.org/chromium/src/chrome/browser/resources/options/search_...

is empty? I'm going to look for the script that does this check and see if has
been updated.

[dmazzoni, 2016-10-19 19:19:58]

It's possible I broke it with this change:

https://codereview.chromium.org/2346393004

Still, I don't understand why it'd only fail on that one bot, and only
starting today. Looks like something is causing those tests to be flaky.

Maybe there was some change to the list of default search engines?

Probably the right fix is just to suppress that error using the existing
mechanism to suppress accessibility audit failures.


On Wed, Oct 19, 2016 at 11:24 AM <huangs@chromium.org> wrote:

> Perhaps that we're breaking
>
>
>
https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rule...
>
> beacause #default-search-engine-list in
>
> <list id="default-search-engine-list"
> class="search-engine-list settings-list"></list>
>
>
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/search_...
>
> is empty? I'm going to look for the script that does this check and see if
> has
> been updated.
>
> https://chromiumcodereview.appspot.com/2422983004/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-10-21 13:08:44]

Description was changed from

==========
Reload ChromeVox panel when reloading ChromeVox into a new profile.

The ChromeVox panel needs to be reloaded when we load ChromeVox into a
new profile.

BUG=645142,646636
TESTED=enable ChromeVox on login screen, then sign in and test that panel still
works, then switch to lock screen and back to login screen
==========

to

==========
Reload ChromeVox panel when reloading ChromeVox into a new profile.

The ChromeVox panel needs to be reloaded when we load ChromeVox into a
new profile.

BUG=645142,646636
TESTED=enable ChromeVox on login screen, then sign in and test that panel still
works, then switch to lock screen and back to login screen

Committed: https://crrev.com/63199b19ad4d7f82913d7fab619cb78237ed7440
Cr-Commit-Position: refs/heads/master@{#426202}
==========

[commit-bot: I haz the power, 2016-10-21 13:08:45]

Patchset 1 (id:??) landed as
https://crrev.com/63199b19ad4d7f82913d7fab619cb78237ed7440
Cr-Commit-Position: refs/heads/master@{#426202}